chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc - Issue 304533003: [fsp] Rename has_next to has_more.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

Issue 304533003: [fsp] Rename has_next to has_more. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/read_directory.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/read_file.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

index a53a8b6cf2c3c347baefd0e6895dc80c9c147fa1..ce7179a2ec3a709e879f145502c3429e8457bacc 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

@@ -203,7 +203,7 @@ TEST_F(FileSystemProviderOperationsReadDirectoryTest, OnSuccess) {

" }\n"

" ],\n"

- " false\n" // has_next

+ " false\n" // has_more

"]\n";

int json_error_code;

@@ -220,8 +220,8 @@ TEST_F(FileSystemProviderOperationsReadDirectoryTest, OnSuccess) {

RequestValue::CreateForReadDirectorySuccess(params.Pass()));

ASSERT_TRUE(request_value.get());

- const bool has_next = false;

- read_directory.OnSuccess(kRequestId, request_value.Pass(), has_next);

+ const bool has_more = false;

+ read_directory.OnSuccess(kRequestId, request_value.Pass(), has_more);

ASSERT_EQ(1u, callback_logger.events().size());

CallbackLogger::Event* event = callback_logger.events()[0];