Issue 304383002: Make GrGLShaderBuilder store a GenProgramOutput

Issue 304383002: Make GrGLShaderBuilder store a GenProgramOutput (Closed)

Created:
6 years, 6 months ago by bsalomon

Modified:
6 years, 6 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Make GrGLShaderBuilder store a GenProgramOutput Committed: http://code.google.com/p/skia/source/detail?r=14982

Patch Set 2 : Fix VS's indentation "fixes" #

Patch Set 4 : try to fix whitespace #

Patch Set 5 : Attempt to revert angle changes #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -117 lines)			Patch
M	src/gpu/gl/GrGLProgram.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.h	View	1 2 3	11 chunks	+27 lines, -39 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1	16 chunks	+62 lines, -74 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + nits/questions https://codereview.chromium.org/304383002/diff/40001/src/gpu/gl/GrGLShaderBuilder.h File src/gpu/gl/GrGLShaderBuilder.h (right): https://codereview.chromium.org/304383002/diff/40001/src/gpu/gl/GrGLShaderBuilder.h#newcode79 src/gpu/gl/GrGLShaderBuilder.h:79: static bool GenProgram(GrGpuGL* gpu, Are we ...

6 years, 6 months ago (2014-05-29 21:12:24 UTC) #2

bsalomon

https://codereview.chromium.org/304383002/diff/40001/src/gpu/gl/GrGLShaderBuilder.h File src/gpu/gl/GrGLShaderBuilder.h (right): https://codereview.chromium.org/304383002/diff/40001/src/gpu/gl/GrGLShaderBuilder.h#newcode79 src/gpu/gl/GrGLShaderBuilder.h:79: static bool GenProgram(GrGpuGL* gpu, On 2014/05/29 21:12:25, robertphillips wrote: ...

6 years, 6 months ago (2014-05-29 21:15:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/304383002/80001

6 years, 6 months ago (2014-05-29 22:13:47 UTC) #5

Message was sent while issue was closed.

Change committed as 14982

Expand Messages | Collapse Messages