Move thumbnail to history component

Move thumbnail to history component

Move //chrome/common/thumbnail_score.{cc,h} into history component
Since it does not depends on anything outside of //base and there
is no plan to componentize thumbnails, it can be moved to
//components/history/core/common

BUG=372363
TEST=unit_tests --gtest_filter=Thumb*
R=sdefresne,blundell,sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276444

[sdefresne, 2014-06-02 19:56:54]

I think you need to update your repository to get the changes that created the
history component (ie. you shouldn't have to create components/history.gypi nor
change components/components.gyp).

https://codereview.chromium.org/304273010/diff/1/chrome/browser/history/DEPS
File chrome/browser/history/DEPS (right):

https://codereview.chromium.org/304273010/diff/1/chrome/browser/history/DEPS#...
chrome/browser/history/DEPS:13: "+components/history/core/common",
This should not be required as //chrome/browser DEPS rules also apply here.

https://codereview.chromium.org/304273010/diff/1/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/304273010/diff/1/chrome/chrome_common.gypi#ne...
chrome/chrome_common.gypi:40: '<(DEPTH)/components/components.gyp:history',
s/history/history_core_common/

https://codereview.chromium.org/304273010/diff/1/components/components.gyp
File components/components.gyp (right):

https://codereview.chromium.org/304273010/diff/1/components/components.gyp#ne...
components/components.gyp:27: 'history.gypi',
This should already be present at HEAD, I think you need to rebase your changes.

https://codereview.chromium.org/304273010/diff/1/components/history.gypi
File components/history.gypi (right):

https://codereview.chromium.org/304273010/diff/1/components/history.gypi#newc...
components/history.gypi:8: 'target_name': 'history',
s/history/history_core_common/

https://codereview.chromium.org/304273010/diff/1/components/history.gypi#newc...
components/history.gypi:9: 'type': '<(component)',
'type' should be 'static_library' here, otherwise your code will not compile.

[blundell, 2014-06-03 08:30:33]

https://codereview.chromium.org/304273010/diff/1/chrome/common/thumbnail_scor...
File chrome/common/thumbnail_score_unittest.cc (left):

https://codereview.chromium.org/304273010/diff/1/chrome/common/thumbnail_scor...
chrome/common/thumbnail_score_unittest.cc:5: #include
"chrome/common/thumbnail_score.h"
This test should move too, and should be run in components_unittests instead of
unit_tests.

[nshaik, 2014-06-08 08:43:41]

sdefresne@,blundell@ for OWNERS

@sky for 
    chrome/browser/thumbnails/thumbnail_service.h
    chrome/browser/thumbnails/thumbnailing_context.h
    chrome/browser/ui/search/instant_extended_interactive_uitest.cc
    chrome/common/thumbnail_score.cc
    chrome/common/thumbnail_score.h
    chrome/common/thumbnail_score_unittest.cc

Please review.

https://codereview.chromium.org/304273010/diff/1/chrome/browser/history/DEPS
File chrome/browser/history/DEPS (right):

https://codereview.chromium.org/304273010/diff/1/chrome/browser/history/DEPS#...
chrome/browser/history/DEPS:13: "+components/history/core/common",
On 2014/06/02 19:56:55, sdefresne wrote:
> This should not be required as //chrome/browser DEPS rules also apply here.

Done.

https://codereview.chromium.org/304273010/diff/1/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/304273010/diff/1/chrome/chrome_common.gypi#ne...
chrome/chrome_common.gypi:40: '<(DEPTH)/components/components.gyp:history',
On 2014/06/02 19:56:55, sdefresne wrote:
> s/history/history_core_common/

Done.

https://codereview.chromium.org/304273010/diff/1/chrome/common/thumbnail_scor...
File chrome/common/thumbnail_score_unittest.cc (left):

https://codereview.chromium.org/304273010/diff/1/chrome/common/thumbnail_scor...
chrome/common/thumbnail_score_unittest.cc:5: #include
"chrome/common/thumbnail_score.h"
On 2014/06/03 08:30:33, blundell wrote:
> This test should move too, and should be run in components_unittests instead
of
> unit_tests.

Done.

https://codereview.chromium.org/304273010/diff/1/components/components.gyp
File components/components.gyp (right):

https://codereview.chromium.org/304273010/diff/1/components/components.gyp#ne...
components/components.gyp:27: 'history.gypi',
On 2014/06/02 19:56:55, sdefresne wrote:
> This should already be present at HEAD, I think you need to rebase your
changes.

Done.

https://codereview.chromium.org/304273010/diff/1/components/history.gypi
File components/history.gypi (right):

https://codereview.chromium.org/304273010/diff/1/components/history.gypi#newc...
components/history.gypi:8: 'target_name': 'history',
On 2014/06/02 19:56:55, sdefresne wrote:
> s/history/history_core_common/

Done.

https://codereview.chromium.org/304273010/diff/1/components/history.gypi#newc...
components/history.gypi:9: 'type': '<(component)',
On 2014/06/02 19:56:55, sdefresne wrote:
> 'type' should be 'static_library' here, otherwise your code will not compile.

Done.

[sky, 2014-06-09 15:54:31]

Said files LGTM

[sdefresne, 2014-06-10 07:56:55]

lgtm

[blundell, 2014-06-10 08:03:42]

LGTM

https://codereview.chromium.org/304273010/diff/20001/components/components_te...
File components/components_tests.gyp (right):

https://codereview.chromium.org/304273010/diff/20001/components/components_te...
components/components_tests.gyp:259: # Dependencies of thumbnail
s/thumbnail/history

https://codereview.chromium.org/304273010/diff/20001/components/components_te...
components/components_tests.gyp:385: ['include', '^gcm_driver/'],
Please add history here so these tests are run on iOS.

[nshaik, 2014-06-11 08:02:27]

https://codereview.chromium.org/304273010/diff/20001/components/components_te...
File components/components_tests.gyp (right):

https://codereview.chromium.org/304273010/diff/20001/components/components_te...
components/components_tests.gyp:259: # Dependencies of thumbnail
On 2014/06/10 08:03:42, blundell wrote:
> s/thumbnail/history

Done.

https://codereview.chromium.org/304273010/diff/20001/components/components_te...
components/components_tests.gyp:385: ['include', '^gcm_driver/'],
On 2014/06/10 08:03:42, blundell wrote:
> Please add history here so these tests are run on iOS.

Done.

[nshaik, 2014-06-11 08:03:53]

The CQ bit was checked by naiem.shaik@gmail.com

[commit-bot: I haz the power, 2014-06-11 08:05:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/naiem.shaik@gmail.com/304273010/40001

[commit-bot: I haz the power, 2014-06-11 14:07:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-11 17:49:31]

Change committed as 276444