components/history.gypi - Issue 304273010: Move thumbnail to history component

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/history.gypi

Issue 304273010: Move thumbnail to history component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 {	5 {

6 'targets': [	6 'targets': [

7 {	7 {

8 'target_name': 'auto_login_parser',	8 'target_name': 'history',
	sdefresne 2014/06/02 19:56:55 s/history/history_core_common/ s/history/history_core_common/ nshaik 2014/06/08 08:43:41 Done. Show quoted text On 2014/06/02 19:56:55, sdefresne wrote: > s/history/history_core_common/ Done.
9 'type': 'static_library',	9 'type': '<(component)',
	sdefresne 2014/06/02 19:56:55 'type' should be 'static_library' here, otherwise 'type' should be 'static_library' here, otherwise your code will not compile. nshaik 2014/06/08 08:43:41 Done. Show quoted text On 2014/06/02 19:56:55, sdefresne wrote: > 'type' should be 'static_library' here, otherwise your code will not compile. Done.
10 'dependencies': [	10 'dependencies': [

11 '../base/base.gyp:base',	11 '../base/base.gyp:base',

12 '../net/net.gyp:net',

13 ],	12 ],

14 'include_dirs': [	13 'include_dirs': [

15 '..',	14 '..',

16 ],	15 ],

17 'sources': [	16 'sources': [

18 'auto_login_parser/auto_login_parser.cc',	17 'history/core/common/thumbnail_score.cc',

19 'auto_login_parser/auto_login_parser.h',	18 'history/core/common/thumbnail_score.h',

20 ],	19 ],

21 },	20 },

22 ],	21 ],

23 }	22 }

OLD	NEW

« components/components.gyp ('K') | « components/components.gyp ('k') | components/history/core/common/thumbnail_score.h » ('j') | no next file with comments »