Issue 304253007: Revert 273770 "Enable touch text selection tests on all Aura pla..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304253007: Revert 273770 "Enable touch text selection tests on all Aura pla..." (Closed)

Created:
6 years, 6 months ago by battre

Modified:
6 years, 6 months ago

Reviewers:
mohsen

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 273770 "Enable touch text selection tests on all Aura pla..." Fails TouchEditableImplAuraTest.TouchCursorInTextfieldTest on Win7. See http://crbug.com/377561#c4 for details. > Enable touch text selection tests on all Aura platforms > > In order to make touch text selection ready for Windows and other Aura > platforms, a prerequisite is to enable tests. Following tests are > enabled: > - TouchSelectionControllerImplTest in views_unittests; > - TouchEditableImplAuraTest in content_browsertests. > > BUG=377561 > > Review URL: https://codereview.chromium.org/304883002 TBR=mohsen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273805

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -30 lines)			Patch
M	trunk/src/content/browser/web_contents/touch_editable_impl_aura.cc	View	1 chunk	+4 lines, -15 lines	0 comments	Download
M	trunk/src/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc	View	5 chunks	+8 lines, -14 lines	0 comments	Download
M	trunk/src/content/content_tests.gypi	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/views.gyp	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

battre

6 years, 6 months ago (2014-05-30 12:03:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r273805 (tree was closed).

Expand Messages | Collapse Messages