Issue 304883002: Enable touch text selection tests on all Aura platforms

Issue 304883002: Enable touch text selection tests on all Aura platforms (Closed)

Created:
6 years, 6 months ago by mohsen

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, darin-cc_chromium.org, jam, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Enable touch text selection tests on all Aura platforms In order to make touch text selection ready for Windows and other Aura platforms, a prerequisite is to enable tests. Following tests are enabled: - TouchSelectionControllerImplTest in views_unittests; - TouchEditableImplAuraTest in content_browsertests. BUG=377561 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273770

Patch Set 1 #

Patch Set 2 : Convert point to root window before screen #

Total comments: 1

Patch Set 3 : Replaced EXPECT_STREQ with EXPECT_EQ #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -22 lines)			Patch
M	content/browser/web_contents/touch_editable_impl_aura.cc	View	1	1 chunk	+15 lines, -4 lines	0 comments	Download
M	content/browser/web_contents/touch_editable_impl_aura_browsertest.cc	View	1 2	5 chunks	+14 lines, -8 lines	0 comments	Download
M	content/content_tests.gypi	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	ui/views/views.gyp	View		1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/304883002/diff/30001/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc File content/browser/web_contents/touch_editable_impl_aura_browsertest.cc (right): https://codereview.chromium.org/304883002/diff/30001/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc#newcode324 content/browser/web_contents/touch_editable_impl_aura_browsertest.cc:324: EXPECT_STREQ("Some ", selection.c_str()); nit: you can just do: ...

6 years, 6 months ago (2014-05-29 19:28:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/304883002/50001

6 years, 6 months ago (2014-05-30 00:11:21 UTC) #4

Message was sent while issue was closed.

Change committed as 273770

Expand Messages | Collapse Messages