Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp - Issue 304223007: Use auto-rethrowing v8::TryCatch variant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

Issue 304223007: Use auto-rethrowing v8::TryCatch variant (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: make constructors explicit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

index 6764c3c0761876d7d4703dfcd4fb34cfc1781c6c..ecb70374a8b5dcec235b814db73ca9743706e17e 100644

--- a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

@@ -73,7 +73,7 @@ static void V8TestInterfaceNamedConstructor2ConstructorCallback(const v8::Functi

}

V8StringResource<> stringArg;

{

- TOSTRING_VOID_INTERNAL_NOTRYCATCH(stringArg, info[0]);

+ TOSTRING_VOID_INTERNAL(stringArg, info[0]);

}

RefPtr<TestInterfaceNamedConstructor2> impl = TestInterfaceNamedConstructor2::createForJSConstructor(*document, stringArg);