Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp - Issue 304223007: Use auto-rethrowing v8::TryCatch variant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

Issue 304223007: Use auto-rethrowing v8::TryCatch variant (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: make constructors explicit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

index 68ba43185963d6b8ec6e44b13afd3c2e3f7192df..11a6d8e934595c6be6be6a0f0f926387a5087fd2 100644

--- a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

@@ -105,6 +105,7 @@ static void V8TestInterfaceNamedConstructorConstructorCallback(const v8::Functio

V8StringResource<> optionalStringArg;

{

v8::TryCatch block;

+ V8RethrowTryCatchScope rethrow(block);

TOSTRING_VOID_INTERNAL(stringArg, info[0]);

TONATIVE_VOID_INTERNAL(defaultUndefinedOptionalBooleanArg, info[1]->BooleanValue());

TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(defaultUndefinedOptionalLongArg, toInt32(info[2], exceptionState), exceptionState);