Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 304203005: Remove const LayerImpl* from QuadSink (Closed)

Created:
6 years, 6 months ago by weiliangc
Modified:
6 years, 6 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, danakj, Ian Vollick, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@onlyQuadSink
Visibility:
Public.

Description

Remove const LayerImpl* from QuadSink (Merged to previous CL 309493002) QuadSink does not need keep track of LayerIml*. LayerImpl is only used when calling Occluded[ContributingSurface]ContentRect function through OcclusionTracker, and it only happens in AppendQuads function from LayerImpl or RenderSurfaceImpl, where the needed LayerImpl can already be found. In LayerImpl::AppendQuads, OcclusionTracker needs this, and in RenderSurfaceImpl::AppendQuads, OT needs owning_layer_. This CL is part of clean up QuadSink. Next CL should be able to remove QuadSink and MockQuadCuller. This CL follows 302603006, 306683002, and 309493002. BUG=344962 TEST=cc_unittests

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -43 lines) Patch
M cc/layers/delegated_renderer_layer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/io_surface_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer_impl.cc View 9 chunks +13 lines, -11 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/quad_sink.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/quad_sink.cc View 2 chunks +4 lines, -4 lines 1 comment Download
M cc/layers/render_surface_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/solid_color_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/surface_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/ui_resource_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_test_common.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/test/mock_quad_culler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/mock_quad_culler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
weiliangc
6 years, 6 months ago (2014-05-30 20:26:50 UTC) #1
enne (OOO)
6 years, 6 months ago (2014-05-30 21:37:01 UTC) #2
lgtm

https://codereview.chromium.org/304203005/diff/1/cc/layers/quad_sink.cc
File cc/layers/quad_sink.cc (left):

https://codereview.chromium.org/304203005/diff/1/cc/layers/quad_sink.cc#oldco...
cc/layers/quad_sink.cc:23: layer_(layer),
Yay, much better.

Powered by Google App Engine
This is Rietveld 408576698