Issue 304153014: Remove element from DynamicType.

Issue 304153014: Remove element from DynamicType. (Closed)

Created:
6 years, 6 months ago by Johnni Winther

Modified:
6 years, 6 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove element from DynamicType. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=36860 Reverted in: https://code.google.com/p/dart/source/detail?r=36870 Committed: https://code.google.com/p/dart/source/detail?r=36873

Patch Set 2 : Add isX properties #

Patch Set 6 : Fix infinite loop. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+314 lines, -314 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/closure.dart	View		6 chunks	+11 lines, -13 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View		5 chunks	+2 lines, -14 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/constants.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View	1	21 chunks	+70 lines, -69 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/enqueue.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/helpers/trace.dart	View	1	2 chunks	+14 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/concrete_types_inferrer.dart	View	1	3 chunks	+4 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	7 chunks	+23 lines, -22 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart	View	1	7 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart	View		3 chunks	+20 lines, -24 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors_used.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/class_members.dart	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2 3	15 chunks	+43 lines, -24 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/registry.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/signatures.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/scannerlib.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	7 chunks	+10 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1 2 3 4 5	24 chunks	+42 lines, -41 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/union_type_mask.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/use_unused_api.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/js_helper.dart	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	tests/compiler/dart2js/members_test.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/type_test_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/304153014/diff/40001/sdk/lib/_internal/compiler/implementation/helpers/trace.dart File sdk/lib/_internal/compiler/implementation/helpers/trace.dart (right): https://codereview.chromium.org/304153014/diff/40001/sdk/lib/_internal/compiler/implementation/helpers/trace.dart#newcode16 sdk/lib/_internal/compiler/implementation/helpers/trace.dart:16: * I prefer changes to the helpers in ...

6 years, 6 months ago (2014-06-02 09:39:38 UTC) #2

Johnni Winther

https://codereview.chromium.org/304153014/diff/40001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/304153014/diff/40001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2131 sdk/lib/_internal/compiler/implementation/resolution/members.dart:2131: // objects that [Element] from this method. On 2014/06/02 ...

6 years, 6 months ago (2014-06-02 09:46:34 UTC) #3

Johnni Winther

Committed patchset #4 manually as r36860 (presubmit successful).

6 years, 6 months ago (2014-06-02 09:50:15 UTC) #4

Johnni Winther

6 years, 6 months ago (2014-06-02 14:01:47 UTC) #7

Message was sent while issue was closed.

Committed patchset #6 manually as r36873 (presubmit successful).

Expand Messages | Collapse Messages