Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 304153014: Remove element from DynamicType. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix infinite loop. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
index baea02ae5ae0ca04b47d4bd6e6044c7c94149574..8a9fd0f2b0156a111a673c616d1b62dd051b89d4 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
@@ -1719,7 +1719,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
native.NativeBehavior nativeBehavior = node.nativeBehavior;
if (nativeBehavior == null) return;
nativeBehavior.typesReturned.forEach((type) {
- if (type is DartType) {
+ if (type is InterfaceType) {
registry.registerInstantiatedType(type);
}
});
@@ -2410,7 +2410,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
handleListOrSupertypeCheck(
input, interceptor, type, negative: negative);
attachLocationToLast(node);
- } else if (type.kind == TypeKind.FUNCTION) {
+ } else if (type.isFunctionType) {
checkType(input, interceptor, type, negative: negative);
attachLocationToLast(node);
} else if ((input.canBePrimitive(compiler)
@@ -2552,7 +2552,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
assert(node.isCheckedModeCheck || node.isCastTypeCheck);
DartType type = node.typeExpression;
assert(type.kind != TypeKind.TYPEDEF);
- if (type.kind == TypeKind.FUNCTION) {
+ if (type.isFunctionType) {
// TODO(5022): We currently generate $isFunction checks for
// function types.
registry.registerIsCheck(compiler.functionClass.rawType);
@@ -2569,7 +2569,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
}
if (helper == null) {
- assert(type.kind == TypeKind.FUNCTION);
+ assert(type.isFunctionType);
use(node.inputs[0]);
} else {
push(helper.generateCall(this, node));
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698