Add browser test for ChromeResourceDispatcherHostDelegate.

Add browser test for ChromeResourceDispatcherHostDelegate.

Also fixed bug in ChromeResourceDispatcherHostDelegate where it was using the wrong URL when detecting whether to add a policy header to a redirect (yay for tests).

BUG=378729
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275498

[Andrew T Wilson (Slow), 2014-06-05 15:16:22]

Jochen, PTAL.

[jochen (gone - plz use gerrit), 2014-06-06 07:18:39]

lgtm with nits

you'll also need to update the unit tests

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
File
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc
(right):

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc:53:
TestDispatcherHostDelegate(
explicit

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc:92:
net::HttpRequestHeaders request_headers_;
should be private

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc:139:
GURL dm_url_;
private

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc:141:
};
disallow copy & assign

[Andrew T Wilson (Slow), 2014-06-06 08:42:19]

Thanks for the quick turnaround (and also the pointer to using BrowserTests for
this instead of trying to make a unit test).

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
File
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc
(right):

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc:53:
TestDispatcherHostDelegate(
On 2014/06/06 07:18:39, jochen traveling until Jun 23 wrote:
> explicit

Done.

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc:92:
net::HttpRequestHeaders request_headers_;
On 2014/06/06 07:18:39, jochen traveling until Jun 23 wrote:
> should be private

Done.

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc:139:
GURL dm_url_;
On 2014/06/06 07:18:39, jochen traveling until Jun 23 wrote:
> private

I use these in the tests below, so they must be public.

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc:141:
};
On 2014/06/06 07:18:39, jochen traveling until Jun 23 wrote:
> disallow copy & assign

Done.

[Andrew T Wilson (Slow), 2014-06-06 08:42:24]

The CQ bit was checked by atwilson@chromium.org

[commit-bot: I haz the power, 2014-06-06 08:43:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/atwilson@chromium.org/303993005/40001

[commit-bot: I haz the power, 2014-06-06 13:33:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[jochen (gone - plz use gerrit), 2014-06-06 13:43:50]

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
File
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc
(right):

https://codereview.chromium.org/303993005/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc:139:
GURL dm_url_;
On 2014/06/06 08:42:19, Andrew T Wilson wrote:
> On 2014/06/06 07:18:39, jochen traveling until Jun 23 wrote:
> > private
> 
> I use these in the tests below, so they must be public.

tests inherit from their fixture, so protected should work

or getters/setters :)

[commit-bot: I haz the power, 2014-06-06 15:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 15:03:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Andrew T Wilson (Slow), 2014-06-06 16:11:05]

The CQ bit was checked by atwilson@chromium.org

[commit-bot: I haz the power, 2014-06-06 16:12:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/atwilson@chromium.org/303993005/60001

[commit-bot: I haz the power, 2014-06-06 19:15:25]

Change committed as 275498