components/policy/core/common/cloud/policy_header_io_helper_unittest.cc - Issue 303993005: Add browser test for ChromeResourceDispatcherHostDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/policy_header_io_helper_unittest.cc

Issue 303993005: Add browser test for ChromeResourceDispatcherHostDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix use-after-free of ResourceDispatcherHostDelegate in test. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/policy_header_io_helper.cc ('k') | components/policy/core/common/cloud/policy_header_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/policy_header_io_helper_unittest.cc

diff --git a/components/policy/core/common/cloud/policy_header_io_helper_unittest.cc b/components/policy/core/common/cloud/policy_header_io_helper_unittest.cc

index b86b260eddd4275888d07252140422e233d8aee9..fdb19bdf5958e537278ecdf8add531465e3bd75f 100644

--- a/components/policy/core/common/cloud/policy_header_io_helper_unittest.cc

+++ b/components/policy/core/common/cloud/policy_header_io_helper_unittest.cc

@@ -51,14 +51,14 @@ class PolicyHeaderIOHelperTest : public testing::Test {

TEST_F(PolicyHeaderIOHelperTest, InitialHeader) {

net::TestURLRequest request(

GURL(kDMServerURL), net::DEFAULT_PRIORITY, NULL, &context_);

- helper_->AddPolicyHeaders(&request);

+ helper_->AddPolicyHeaders(request.url(), &request);

ValidateHeader(request.extra_request_headers(), kInitialPolicyHeader);

}

TEST_F(PolicyHeaderIOHelperTest, NoHeaderOnNonMatchingURL) {

net::TestURLRequest request(

GURL("http://non-matching.com"), net::DEFAULT_PRIORITY, NULL, &context_);

- helper_->AddPolicyHeaders(&request);

+ helper_->AddPolicyHeaders(request.url(), &request);

EXPECT_TRUE(request.extra_request_headers().IsEmpty());

}

@@ -68,7 +68,7 @@ TEST_F(PolicyHeaderIOHelperTest, HeaderChange) {

task_runner_->RunUntilIdle();

net::TestURLRequest request(

GURL(kDMServerURL), net::DEFAULT_PRIORITY, NULL, &context_);

- helper_->AddPolicyHeaders(&request);

+ helper_->AddPolicyHeaders(request.url(), &request);

ValidateHeader(request.extra_request_headers(), new_header);

}

@@ -77,7 +77,7 @@ TEST_F(PolicyHeaderIOHelperTest, ChangeToNoHeader) {

task_runner_->RunUntilIdle();

net::TestURLRequest request(

GURL(kDMServerURL), net::DEFAULT_PRIORITY, NULL, &context_);

- helper_->AddPolicyHeaders(&request);

+ helper_->AddPolicyHeaders(request.url(), &request);

EXPECT_TRUE(request.extra_request_headers().IsEmpty());

}