Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
303723003:
Lock Rotation on user settings changes (Closed)
|
Created:
6 years, 7 months ago by jonross Modified:
6 years, 6 months ago CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionLock Rotation on user settings changes
While in MaximizeMode if the rotation of the internal display is changed by a source other than MaximizeModeController rotation lock will be set. Thereby blocking future accelerometer rotations until the user toggles the lock.
The rotation lock tray will listen for these changes and update its visuals.
TEST=MaximizeModeControllerTest
BUG=371426, 369505
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276699
Patch Set 1 #
Total comments: 23
Patch Set 2 : #
Total comments: 13
Patch Set 3 : #
Total comments: 2
Patch Set 4 : #
Total comments: 1
Patch Set 5 : Also update current rotation #
Total comments: 2
Patch Set 6 : Add test for edge case #Patch Set 7 : Rebase #
Messages
Total messages: 31 (0 generated)
Hi Rob, Please review the implementation of rotation lock on user display configuration changes.
https://codereview.chromium.org/303723003/diff/1/ash/system/chromeos/rotation... File ash/system/chromeos/rotation/tray_rotation_lock.cc (left): https://codereview.chromium.org/303723003/diff/1/ash/system/chromeos/rotation... ash/system/chromeos/rotation/tray_rotation_lock.cc:66: SetVisible(rotation_locked); Nice to be able to remove this! :-) https://codereview.chromium.org/303723003/diff/1/ash/system/chromeos/rotation... File ash/system/chromeos/rotation/tray_rotation_lock.cc (right): https://codereview.chromium.org/303723003/diff/1/ash/system/chromeos/rotation... ash/system/chromeos/rotation/tray_rotation_lock.cc:62: nit: I don't think the empty lines are necessary to break up this short function. https://codereview.chromium.org/303723003/diff/1/ash/system/chromeos/rotation... ash/system/chromeos/rotation/tray_rotation_lock.cc:114: tray_view()->SetVisible(GetInitialVisibility()); Can you move the logic in GetInitialVisibility to something more appropriately named. You can call this new function from GetInitialVisibility. Perhaps GetCurrentVisibility, or ShouldBeVisible? https://codereview.chromium.org/303723003/diff/1/ash/system/chromeos/rotation... ash/system/chromeos/rotation/tray_rotation_lock.cc:133: // Upon system shutdown the controller could already be cleaned up. Isn't the controller at least around when OnMaximizeModeEnded is called? If not, it might make sense to make sure that maximize mode ends before the controller is destructed. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... File ash/wm/maximize_mode/maximize_mode_controller.cc (right): https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.cc:199: user_rotation_ = display_manager-> Updating the user_rotation_ might be an unexpected consequence if it actually isn't different than the current_rotation_. I think I'd prefer to only update this if it's not current_rotation_ so that resolution changes or other things don't change the exit rotation. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.cc:201: if (user_rotation_ != current_rotation_) nit: It would be helpful to have a comment here. Presumably this is because the user may have changed any display configuration, not just the rotation so we only lock if rotation changes. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.cc:247: if (!maximize_mode_engaged || rotation_locked_) It might be useful to track accelerometer rotation even if the screen is locked so that on unlocking the rotation can be immediately updated. Not that important though since it will be updated soon, maybe just a TODO? https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.cc:253: gfx::Display::InternalDisplayId()).rotation(); This might be a local variable now. current_rotation_ maybe? https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.cc:316: user_rotation_ = display_manager-> nit: Just use current_rotation_ = user_rotation_ = display_manager->... https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... File ash/wm/maximize_mode/maximize_mode_controller.h (right): https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.h:34: class ASH_EXPORT Observer { I don't think ASH_EXPORT is necessary on a nested class. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.h:37: virtual void OnRotationLockChanged() {} You could pass the new rotation lock state. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.h:120: // The current rotation set by MaximizdeModeController for the internal s/MaxizdeModeController/MaximizeModeController
https://codereview.chromium.org/303723003/diff/1/ash/system/chromeos/rotation... File ash/system/chromeos/rotation/tray_rotation_lock.cc (right): https://codereview.chromium.org/303723003/diff/1/ash/system/chromeos/rotation... ash/system/chromeos/rotation/tray_rotation_lock.cc:62: On 2014/05/28 14:48:04, flackr wrote: > nit: I don't think the empty lines are necessary to break up this short > function. Well at one point in the past it was a fat method. Done. https://codereview.chromium.org/303723003/diff/1/ash/system/chromeos/rotation... ash/system/chromeos/rotation/tray_rotation_lock.cc:114: tray_view()->SetVisible(GetInitialVisibility()); On 2014/05/28 14:48:04, flackr wrote: > Can you move the logic in GetInitialVisibility to something more appropriately > named. You can call this new function from GetInitialVisibility. Perhaps > GetCurrentVisibility, or ShouldBeVisible? Done. https://codereview.chromium.org/303723003/diff/1/ash/system/chromeos/rotation... ash/system/chromeos/rotation/tray_rotation_lock.cc:133: // Upon system shutdown the controller could already be cleaned up. On 2014/05/28 14:48:04, flackr wrote: > Isn't the controller at least around when OnMaximizeModeEnded is called? If not, > it might make sense to make sure that maximize mode ends before the controller > is destructed. Done. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... File ash/wm/maximize_mode/maximize_mode_controller.cc (right): https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.cc:199: user_rotation_ = display_manager-> On 2014/05/28 14:48:04, flackr wrote: > Updating the user_rotation_ might be an unexpected consequence if it actually > isn't different than the current_rotation_. I think I'd prefer to only update > this if it's not current_rotation_ so that resolution changes or other things > don't change the exit rotation. Done. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.cc:201: if (user_rotation_ != current_rotation_) On 2014/05/28 14:48:04, flackr wrote: > nit: It would be helpful to have a comment here. Presumably this is because the > user may have changed any display configuration, not just the rotation so we > only lock if rotation changes. Done. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.cc:247: if (!maximize_mode_engaged || rotation_locked_) On 2014/05/28 14:48:04, flackr wrote: > It might be useful to track accelerometer rotation even if the screen is locked > so that on unlocking the rotation can be immediately updated. Not that important > though since it will be updated soon, maybe just a TODO? Added todo https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.cc:253: gfx::Display::InternalDisplayId()).rotation(); On 2014/05/28 14:48:04, flackr wrote: > This might be a local variable now. current_rotation_ maybe? This can be switched when we address the todo for line 247. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.cc:316: user_rotation_ = display_manager-> On 2014/05/28 14:48:04, flackr wrote: > nit: Just use current_rotation_ = user_rotation_ = display_manager->... Done. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... File ash/wm/maximize_mode/maximize_mode_controller.h (right): https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.h:34: class ASH_EXPORT Observer { On 2014/05/28 14:48:04, flackr wrote: > I don't think ASH_EXPORT is necessary on a nested class. Done. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.h:37: virtual void OnRotationLockChanged() {} On 2014/05/28 14:48:04, flackr wrote: > You could pass the new rotation lock state. Done. https://codereview.chromium.org/303723003/diff/1/ash/wm/maximize_mode/maximiz... ash/wm/maximize_mode/maximize_mode_controller.h:120: // The current rotation set by MaximizdeModeController for the internal On 2014/05/28 14:48:04, flackr wrote: > s/MaxizdeModeController/MaximizeModeController Done.
https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... File ash/system/chromeos/rotation/tray_rotation_lock.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... ash/system/chromeos/rotation/tray_rotation_lock.cc:58: bool rotation_locked = !maximize_mode_controller->rotation_locked(); nit: No need to store value, as it's only used once, just calculate in following line. https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... File ash/system/chromeos/rotation/tray_rotation_lock.h (right): https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... ash/system/chromeos/rotation/tray_rotation_lock.h:52: bool ShouldBeVisible(); Functions before variables: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Declar... nit: const https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... File ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc:135: Verify that rotation lock changed externally notifies and updates visibility? https://codereview.chromium.org/303723003/diff/20001/ash/wm/maximize_mode/max... File ash/wm/maximize_mode/maximize_mode_controller.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/wm/maximize_mode/max... ash/wm/maximize_mode/maximize_mode_controller.cc:197: if (rotation_locked_ || in_set_screen_rotation_) If rotation is locked you should still track updates to the user_rotation_ which you'll be exiting to.
https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... File ash/system/chromeos/rotation/tray_rotation_lock.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... ash/system/chromeos/rotation/tray_rotation_lock.cc:58: bool rotation_locked = !maximize_mode_controller->rotation_locked(); On 2014/05/30 00:47:24, flackr wrote: > nit: No need to store value, as it's only used once, just calculate in following > line. Done. https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... File ash/system/chromeos/rotation/tray_rotation_lock.h (right): https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... ash/system/chromeos/rotation/tray_rotation_lock.h:52: bool ShouldBeVisible(); On 2014/05/30 00:47:24, flackr wrote: > Functions before variables: > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Declar... > nit: const Done. https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... File ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc:135: On 2014/05/30 00:47:24, flackr wrote: > Verify that rotation lock changed externally notifies and updates visibility? Tested by TrayViewVisibilityChangesDuringMaximizeMode (line 102) https://codereview.chromium.org/303723003/diff/20001/ash/wm/maximize_mode/max... File ash/wm/maximize_mode/maximize_mode_controller.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/wm/maximize_mode/max... ash/wm/maximize_mode/maximize_mode_controller.cc:197: if (rotation_locked_ || in_set_screen_rotation_) On 2014/05/30 00:47:24, flackr wrote: > If rotation is locked you should still track updates to the user_rotation_ which > you'll be exiting to. Done.
https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... File ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc:135: On 2014/05/30 14:52:44, jonross wrote: > On 2014/05/30 00:47:24, flackr wrote: > > Verify that rotation lock changed externally notifies and updates visibility? > > Tested by TrayViewVisibilityChangesDuringMaximizeMode (line 102) It seems like in this test you create the tray view *after) setting the rotation lock, not before setting it. I wouldn't expect an existing test for this to pass since you just added the observer. https://codereview.chromium.org/303723003/diff/20001/ash/wm/maximize_mode/max... File ash/wm/maximize_mode/maximize_mode_controller.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/wm/maximize_mode/max... ash/wm/maximize_mode/maximize_mode_controller.cc:197: if (rotation_locked_ || in_set_screen_rotation_) On 2014/05/30 14:52:44, jonross wrote: > On 2014/05/30 00:47:24, flackr wrote: > > If rotation is locked you should still track updates to the user_rotation_ > which > > you'll be exiting to. > > Done. Not exactly, if the rotation changes to current_rotation_ (which is still what the accelerometer was reading when we locked the rotation), we won't record it as the user_rotation_. If the rotation is locked we should just update user_rotation_ to the new rotation. https://codereview.chromium.org/303723003/diff/40001/ash/system/chromeos/rota... File ash/system/chromeos/rotation/tray_rotation_lock.cc (right): https://codereview.chromium.org/303723003/diff/40001/ash/system/chromeos/rota... ash/system/chromeos/rotation/tray_rotation_lock.cc:59: SetRotationLocked(!maximize_mode_controller->rotation_locked()); nit: prefer wrapping at ( rather than at -> when possible.
https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... File ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/system/chromeos/rota... ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc:135: On 2014/05/30 18:58:59, flackr wrote: > On 2014/05/30 14:52:44, jonross wrote: > > On 2014/05/30 00:47:24, flackr wrote: > > > Verify that rotation lock changed externally notifies and updates > visibility? > > > > Tested by TrayViewVisibilityChangesDuringMaximizeMode (line 102) > > It seems like in this test you create the tray view *after) setting the rotation > lock, not before setting it. > > I wouldn't expect an existing test for this to pass since you just added the > observer. Updated the above tests. During other changes two ended up testing the same behaviour. Repurposed one to perform the desired test. https://codereview.chromium.org/303723003/diff/40001/ash/system/chromeos/rota... File ash/system/chromeos/rotation/tray_rotation_lock.cc (right): https://codereview.chromium.org/303723003/diff/40001/ash/system/chromeos/rota... ash/system/chromeos/rotation/tray_rotation_lock.cc:59: SetRotationLocked(!maximize_mode_controller->rotation_locked()); On 2014/05/30 18:58:59, flackr wrote: > nit: prefer wrapping at ( rather than at -> when possible. Done.
https://codereview.chromium.org/303723003/diff/20001/ash/wm/maximize_mode/max... File ash/wm/maximize_mode/maximize_mode_controller.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/wm/maximize_mode/max... ash/wm/maximize_mode/maximize_mode_controller.cc:197: if (rotation_locked_ || in_set_screen_rotation_) On 2014/05/30 18:58:59, flackr wrote: > On 2014/05/30 14:52:44, jonross wrote: > > On 2014/05/30 00:47:24, flackr wrote: > > > If rotation is locked you should still track updates to the user_rotation_ > > which > > > you'll be exiting to. > > > > Done. > > Not exactly, if the rotation changes to current_rotation_ (which is still what > the accelerometer was reading when we locked the rotation), we won't record it > as the user_rotation_. If the rotation is locked we should just update > user_rotation_ to the new rotation. Not changed yet?
https://codereview.chromium.org/303723003/diff/20001/ash/wm/maximize_mode/max... File ash/wm/maximize_mode/maximize_mode_controller.cc (right): https://codereview.chromium.org/303723003/diff/20001/ash/wm/maximize_mode/max... ash/wm/maximize_mode/maximize_mode_controller.cc:197: if (rotation_locked_ || in_set_screen_rotation_) On 2014/06/02 15:11:11, flackr wrote: > On 2014/05/30 18:58:59, flackr wrote: > > On 2014/05/30 14:52:44, jonross wrote: > > > On 2014/05/30 00:47:24, flackr wrote: > > > > If rotation is locked you should still track updates to the user_rotation_ > > > which > > > > you'll be exiting to. > > > > > > Done. > > > > Not exactly, if the rotation changes to current_rotation_ (which is still what > > the accelerometer was reading when we locked the rotation), we won't record it > > as the user_rotation_. If the rotation is locked we should just update > > user_rotation_ to the new rotation. > > Not changed yet? Apparently this is listed in the Diff from Patch #2 https://codereview.chromium.org/303723003/diff/60001/ash/wm/maximize_mode/max... File ash/wm/maximize_mode/maximize_mode_controller.cc (right): https://codereview.chromium.org/303723003/diff/60001/ash/wm/maximize_mode/max... ash/wm/maximize_mode/maximize_mode_controller.cc:197: if (in_set_screen_rotation_) Strange that this is only showing as a diff from patch #2. The change is here. SetRotationLock is a no-op if were are currently locked. So this will only set the updated rotation in that case.
https://codereview.chromium.org/303723003/diff/120001/ash/wm/maximize_mode/ma... File ash/wm/maximize_mode/maximize_mode_controller.cc (right): https://codereview.chromium.org/303723003/diff/120001/ash/wm/maximize_mode/ma... ash/wm/maximize_mode/maximize_mode_controller.cc:208: current_rotation_ = user_rotation; Thanks. Can we have a test for this since it almost went overlooked?
https://codereview.chromium.org/303723003/diff/120001/ash/wm/maximize_mode/ma... File ash/wm/maximize_mode/maximize_mode_controller.cc (right): https://codereview.chromium.org/303723003/diff/120001/ash/wm/maximize_mode/ma... ash/wm/maximize_mode/maximize_mode_controller.cc:208: current_rotation_ = user_rotation; On 2014/06/02 18:39:29, flackr wrote: > Thanks. Can we have a test for this since it almost went overlooked? Done.
lgtm
Hi Oshima, Could you review this change to set rotation lock when a user changes the display preferences?
hi, sorry I somehow missed your CL. I'll review this weekends.
lgtm
The CQ bit was checked by jonross@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/303723003/140001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...) android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...) android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...) linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...) mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...) mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
The CQ bit was checked by jonross@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/303723003/150001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was checked by jonross@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/303723003/150001
Message was sent while issue was closed.
Change committed as 276699
Message was sent while issue was closed.
Change committed as 276699
Message was sent while issue was closed.
Change committed as 276699 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
