ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc - Issue 303723003: Lock Rotation on user settings changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc

Issue 303723003: Lock Rotation on user settings changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc

diff --git a/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc b/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc

index d38c709b7eda29d4d8228b97c9d0773f5c657366..3b0eb86175d2740451740fc551e54b9ecaecaee0 100644

--- a/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc

+++ b/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc

@@ -118,21 +118,21 @@ TEST_F(TrayRotationLockTest, CreateTrayViewDuringMaximizeModeAndRotationLock) {

TearDownViews();

Shell::GetInstance()->maximize_mode_controller()->

EnableMaximizeModeWindowManager(true);

- Shell::GetInstance()-> maximize_mode_controller()->set_rotation_locked(true);

+ Shell::GetInstance()-> maximize_mode_controller()->SetRotationLocked(true);

SetUpForStatusAreaWidget(StatusAreaWidgetTestHelper::GetStatusAreaWidget());

EXPECT_TRUE(tray_view()->visible());

Shell::GetInstance()->maximize_mode_controller()->

EnableMaximizeModeWindowManager(false);

+ EXPECT_FALSE(tray_view()->visible());

}

// Tests that the enabling of MaximizeMode affects a previously created tray

// view, changing the visibility.

TEST_F(TrayRotationLockTest, TrayViewVisibilityChangesDuringMaximizeMode) {

- TearDownViews();

+ ASSERT_FALSE(tray_view()->visible());

Shell::GetInstance()->maximize_mode_controller()->

EnableMaximizeModeWindowManager(true);

- Shell::GetInstance()-> maximize_mode_controller()->set_rotation_locked(true);

- SetUpForStatusAreaWidget(StatusAreaWidgetTestHelper::GetStatusAreaWidget());

+ Shell::GetInstance()->maximize_mode_controller()->SetRotationLocked(true);

EXPECT_TRUE(tray_view()->visible());

Shell::GetInstance()->maximize_mode_controller()->

EnableMaximizeModeWindowManager(false);