Issue 3037053: A quick fix for Bug 51036...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3037053: A quick fix for Bug 51036... (Closed)

Created:
10 years, 4 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Andrew T Wilson (Slow), dglazkov, dglazkov1

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A quick fix for Bug 51036 This change just back-ports the WebKit change 64470 <http://trac.webkit.org/changeset/64470>;, which integrates support for a printscreen key and an insert key into DumpRenderTree, to our test_shell. BUG=51036 TEST=fast/events/special-key-events-in-input-text.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57503

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	webkit/tools/test_shell/event_sending_controller.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Greetings atwilson, Even though this "special-keyevents-in-input-test.html" seems to be rebaselined on Windows and Mac, we ...

10 years, 4 months ago (2010-08-13 07:30:52 UTC) #3

Andrew T Wilson (Slow)

10 years, 4 months ago (2010-08-13 16:30:06 UTC) #4

The best thing to do at this point would be for you to create a bug at
bugs.webkit.org and submit a patch that removes the unnecessary files. There's
no need to be a committer to do this - the reviewer can submit your change to
the WebKit commit queue on your behalf, if you set the commit-queue: ? flag on
your patch.

Expand Messages | Collapse Messages