Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 3037053: A quick fix for Bug 51036... (Closed)

Created:
10 years, 4 months ago by Hironori Bono
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

A quick fix for Bug 51036 This change just back-ports the WebKit change 64470 <http://trac.webkit.org/changeset/64470>;, which integrates support for a printscreen key and an insert key into DumpRenderTree, to our test_shell. BUG=51036 TEST=fast/events/special-key-events-in-input-text.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57503

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webkit/tools/test_shell/event_sending_controller.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hironori Bono
10 years, 3 months ago (2010-08-09 09:07:12 UTC) #1
dglazkov1
LGTM.
10 years, 3 months ago (2010-08-09 14:07:57 UTC) #2
Hironori Bono
Greetings atwilson, Even though this "special-keyevents-in-input-test.html" seems to be rebaselined on Windows and Mac, we ...
10 years, 3 months ago (2010-08-13 07:30:52 UTC) #3
Andrew T Wilson (Slow)
10 years, 3 months ago (2010-08-13 16:30:06 UTC) #4
The best thing to do at this point would be for you to create a bug at
bugs.webkit.org and submit a patch that removes the unnecessary files. There's
no need to be a committer to do this - the reviewer can submit your change to
the WebKit commit queue on your behalf, if you set the commit-queue: ? flag on
your patch.

Powered by Google App Engine
This is Rietveld 408576698