Chromium Code Reviews
Help | Chromium Project | Sign in

Issue 3036043: icu: Adjust compiler check to exclude VS 2008.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
6 years, 2 months ago by Evan Martin
5 years, 5 months ago


icu: Adjust compiler check to exclude VS 2008. I get a multiple definition error when building this file. The comment above it indicates that exluding this code on VS2008 is the correct thing to do, so I suspect the test was just wrong. Committed:

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M source/common/stringpiece.cpp View 1 chunk +1 line, -1 line 1 comment Download
Trybot results:
Commit queue not available (can’t edit this change).


Total messages: 5 (0 generated)
Evan Martin
I have no idea what I'm doing, but this change at least makes the code ...
6 years, 2 months ago (2010-08-04 22:14:16 UTC) #1
Evan Martin
6 years, 2 months ago (2010-08-04 22:14:54 UTC) #2
brettw (ping on IM after 24h)
6 years, 2 months ago (2010-08-04 22:20:24 UTC) #3
M-A Ruel File source/common/stringpiece.cpp (right): source/common/stringpiece.cpp:48: * Cygwin with MSVC 9.0 also complains here about ...
6 years, 2 months ago (2010-08-04 22:35:25 UTC) #4
jungshik at google
6 years, 2 months ago (2010-08-25 02:24:11 UTC) #5
Thank you for fixing this. I upstreamed the fix ( )
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 9387bc4