Chromium Code Reviews
Help | Chromium Project | Sign in
(358)

Issue 3036043: icu: Adjust compiler check to exclude VS 2008.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Evan Martin
Modified:
2 years, 11 months ago
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

icu: Adjust compiler check to exclude VS 2008.

I get a multiple definition error when building this file.
The comment above it indicates that exluding this code on VS2008
is the correct thing to do, so I suspect the test was just wrong.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54982

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Lint Patch
M source/common/stringpiece.cpp View 1 chunk +1 line, -1 line 1 comment 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 5
Evan Martin
I have no idea what I'm doing, but this change at least makes the code ...
3 years, 8 months ago #1
Evan Martin
3 years, 8 months ago #2
brettw
LGTM
3 years, 8 months ago #3
M-A Ruel
http://codereview.chromium.org/3036043/diff/1/2 File source/common/stringpiece.cpp (right): http://codereview.chromium.org/3036043/diff/1/2#newcode48 source/common/stringpiece.cpp:48: * Cygwin with MSVC 9.0 also complains here about ...
3 years, 8 months ago #4
Jungshik Shin
3 years, 8 months ago #5
Thank you for fixing this. I upstreamed the fix (
http://bugs.icu-project.org/trac/ticket/7906 )
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6