Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: source/common/stringpiece.cpp

Issue 3036043: icu: Adjust compiler check to exclude VS 2008.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu42/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: source/common/stringpiece.cpp
===================================================================
--- source/common/stringpiece.cpp (revision 53046)
+++ source/common/stringpiece.cpp (working copy)
@@ -47,7 +47,7 @@
* Visual Studios 9.0.
* Cygwin with MSVC 9.0 also complains here about redefinition.
M-A Ruel 2010/08/04 22:35:26 I wonder what's "cygwin with msvc9"
*/
-#if (!defined(_MSC_VER) || (_MSC_VER >= 1500)) && !defined(CYGWINMSVC)
+#if (!defined(_MSC_VER) || (_MSC_VER > 1500)) && !defined(CYGWINMSVC)
const int32_t StringPiece::npos;
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698