Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: Source/platform/graphics/media/MediaPlayer.h

Issue 303593002: Oilpan: prevent player from accessing its media element during finalization (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rephrase player finalization as detaching Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/media/MediaPlayer.h
diff --git a/Source/platform/graphics/media/MediaPlayer.h b/Source/platform/graphics/media/MediaPlayer.h
index a8fe49d367c14ebd28f49e5a63658ed121bc9d25..130f01562891ac86e57ad323f17c8bfa1b4354d6 100644
--- a/Source/platform/graphics/media/MediaPlayer.h
+++ b/Source/platform/graphics/media/MediaPlayer.h
@@ -95,6 +95,7 @@ public:
virtual void mediaPlayerDidRemoveTextTrack(blink::WebInbandTextTrack*) = 0;
virtual void mediaPlayerMediaSourceOpened(blink::WebMediaSource*) = 0;
+
};
typedef PassOwnPtr<MediaPlayer> (*CreateMediaEnginePlayer)(MediaPlayerClient*);
@@ -110,6 +111,8 @@ public:
MediaPlayer() { }
virtual ~MediaPlayer() { }
+ virtual void detach() = 0;
+
virtual void load(blink::WebMediaPlayer::LoadType, const String& url, blink::WebMediaPlayer::CORSMode) = 0;
virtual void play() = 0;
@@ -163,6 +166,7 @@ public:
virtual AudioSourceProvider* audioSourceProvider() = 0;
#endif
virtual blink::WebMediaPlayer* webMediaPlayer() const = 0;
+
};
}

Powered by Google App Engine
This is Rietveld 408576698