Source/web/WebMediaPlayerClientImpl.h - Issue 303593002: Oilpan: prevent player from accessing its media element during finalization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebMediaPlayerClientImpl.h

Issue 303593002: Oilpan: prevent player from accessing its media element during finalization (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rephrase player finalization as detaching Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLMediaElement.cpp ('K') | « Source/platform/graphics/media/MediaPlayer.h ('k') | Source/web/WebMediaPlayerClientImpl.cpp » ('j') | Source/web/WebMediaPlayerClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/WebMediaPlayerClientImpl.h

diff --git a/Source/web/WebMediaPlayerClientImpl.h b/Source/web/WebMediaPlayerClientImpl.h

index 7d70f76b8dd371f72855a45377290a21295aadb1..fe88be19ea2d5eed37981267a0203059c47afe22 100644

--- a/Source/web/WebMediaPlayerClientImpl.h

+++ b/Source/web/WebMediaPlayerClientImpl.h

@@ -92,6 +92,7 @@ public:

virtual void requestSeek(double) OVERRIDE;

// MediaPlayer methods:

+ virtual void detach() OVERRIDE;

virtual WebMediaPlayer* webMediaPlayer() const OVERRIDE;

virtual void load(WebMediaPlayer::LoadType, const WTF::String& url, WebMediaPlayer::CORSMode) OVERRIDE;

virtual void play() OVERRIDE;