Initial work towards public Android recipes

scripts/slave/recipe_modules/chromium_android/api.py

Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index 3e2433c3810331ca0d5ddd6ea93e81cfb7f8f9a1..aa23d0c37d782012cbbcc2dbd5b4bab3a21d22a1 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -200,6 +200,34 @@ class AndroidApi(recipe_api.RecipeApi):
     kwargs['env'] = self.get_env()
     return self.m.chromium.compile(**kwargs)
 
+  def findbugs(self):
+    cmd = [self.m.path['checkout'].join('build', 'android', 'findbugs_diff.py')]
+    if self.m.chromium.c.BUILD_CONFIG == 'Release':
+      cmd.append('--release-build')
+    yield self.m.step('findbugs', cmd, env=self.get_env())
+
+    # If findbugs fails, there could be stale class files. Delete them, and
+    # next run maybe we'll do better.
+    if self.m.step_history.last_step().retcode != 0:
+      yield self.m.path.rmwildcard(
+          '*.class',
+          self.m.path['checkout'].join('out'),

[Michael Achenbach, 2014/05/28 14:23:27]

Just to make sure: The files are not in e.g. out/Release?

The out dir might also be more formally in self.m.chromium.c.build_dir.

[Paweł Hajdan Jr., 2014/05/30 09:49:00]

I don't know, this is just restoring public version of the code that got deleted
meanwhile.

+          always_run=True)
+
+    cmd = [self.m.path['checkout'].join('tools', 'android', 'findbugs_plugin',
+               'test', 'run_findbugs_plugin_tests.py')]
+    if self.m.chromium.c.BUILD_CONFIG == 'Release':
+      cmd.append('--release-build')
+    yield self.m.step('findbugs_tests', cmd, env=self.get_env())
+
+  def checklicenses(self):
+    yield self.m.step(
+      'check_licenses',
+      [self.m.path['checkout'].join('android_webview', 'tools',
+                                    'webview_licenses.py'),
+       'scan'],
+      env=self.get_env())
+
   def git_number(self):
     yield self.m.step(
         'git_number',
@@ -270,7 +298,7 @@ class AndroidApi(recipe_api.RecipeApi):
          self.m.chromium.c.build_dir.join('logcat')],
         env=self.get_env(), can_fail_build=False)
 
-  def device_status_check(self, restart_usb=False):
+  def device_status_check(self, restart_usb=False, **kwargs):
     args = []
     if restart_usb:
       args = ['--restart-usb']
@@ -278,15 +306,17 @@ class AndroidApi(recipe_api.RecipeApi):
         'device_status_check',
         [self.m.path['checkout'].join('build', 'android', 'buildbot',
                               'bb_device_status_check.py')] + args,
-        env=self.get_env())
+        env=self.get_env(),
+        **kwargs)
 
-  def provision_devices(self):
+  def provision_devices(self, **kwargs):
     yield self.m.python(
         'provision_devices',
         self.m.path['checkout'].join(
             'build', 'android', 'provision_devices.py'),
         args=['-t', self.m.chromium.c.BUILD_CONFIG],
-        can_fail_build=False)
+        can_fail_build=False,
+        **kwargs)
 
   def detect_and_setup_devices(self):
     yield self.device_status_check()