Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 303473004: Remove the UseCounters for the capture attribute (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 6 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Visibility:
Public.

Description

Remove the UseCounters for the capture attribute Both of the counters are at 0%: http://www.chromestatus.com/metrics/feature/timeline/popularity/86 http://www.chromestatus.com/metrics/feature/timeline/popularity/245 In other worlds, there's hardly anyone to see the deprecation message. BUG=240252 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
M Source/core/frame/UseCounter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
Raphael, can you PTAL? If you approve, I'll get owners review later.
6 years, 7 months ago (2014-05-27 18:50:08 UTC) #1
Raphael Kubo da Costa (rakuco)
looks ok to me, thanks.
6 years, 6 months ago (2014-05-28 11:45:09 UTC) #2
philipj_slow
Jochen, Raphael seems OK with this, can you PTAL?
6 years, 6 months ago (2014-05-28 12:01:42 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-05-28 12:25:13 UTC) #4
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-05-28 12:30:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/303473004/1
6 years, 6 months ago (2014-05-28 12:31:07 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 12:47:45 UTC) #7
Message was sent while issue was closed.
Change committed as 174966

Powered by Google App Engine
This is Rietveld 408576698