Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 303473004: Remove the UseCounters for the capture attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/forms/FileInputType.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 1664 matching lines...) Expand 10 before | Expand all | Expand 10 after
1675 String HTMLInputElement::defaultToolTip() const 1675 String HTMLInputElement::defaultToolTip() const
1676 { 1676 {
1677 return m_inputType->defaultToolTip(); 1677 return m_inputType->defaultToolTip();
1678 } 1678 }
1679 1679
1680 bool HTMLInputElement::shouldAppearIndeterminate() const 1680 bool HTMLInputElement::shouldAppearIndeterminate() const
1681 { 1681 {
1682 return m_inputType->supportsIndeterminateAppearance() && indeterminate(); 1682 return m_inputType->supportsIndeterminateAppearance() && indeterminate();
1683 } 1683 }
1684 1684
1685 #if ENABLE(MEDIA_CAPTURE)
1686 bool HTMLInputElement::capture() const
1687 {
1688 if (!isFileUpload() || !fastHasAttribute(captureAttr))
1689 return false;
1690
1691 // As per crbug.com/240252, emit a deprecation warning when the "capture"
1692 // attribute is used as an enum. The spec has been updated and "capture" is
1693 // supposed to be used as a boolean.
1694 bool hasDeprecatedUsage = !fastGetAttribute(captureAttr).isEmpty();
1695 if (hasDeprecatedUsage)
1696 UseCounter::countDeprecation(document(), UseCounter::CaptureAttributeAsE num);
1697 else
1698 UseCounter::count(document(), UseCounter::CaptureAttributeAsBoolean);
1699
1700 return true;
1701 }
1702 #endif
1703
1704 bool HTMLInputElement::isInRequiredRadioButtonGroup() 1685 bool HTMLInputElement::isInRequiredRadioButtonGroup()
1705 { 1686 {
1706 ASSERT(isRadioButton()); 1687 ASSERT(isRadioButton());
1707 if (RadioButtonGroupScope* scope = radioButtonGroupScope()) 1688 if (RadioButtonGroupScope* scope = radioButtonGroupScope())
1708 return scope->isInRequiredGroup(this); 1689 return scope->isInRequiredGroup(this);
1709 return false; 1690 return false;
1710 } 1691 }
1711 1692
1712 HTMLInputElement* HTMLInputElement::checkedRadioButtonForGroup() const 1693 HTMLInputElement* HTMLInputElement::checkedRadioButtonForGroup() const
1713 { 1694 {
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
1876 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer()); 1857 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
1877 } 1858 }
1878 #endif 1859 #endif
1879 1860
1880 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue) 1861 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue)
1881 { 1862 {
1882 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ; 1863 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ;
1883 } 1864 }
1884 1865
1885 } // namespace 1866 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/forms/FileInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698