Move the FaviconClient implementation to ChromeFaviconClient.

Move the FaviconClient implementation to ChromeFaviconClient.

This is an intermediary CL. The FaviconClient is moving towards being a KeyedService.

BUG=377505
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272896

[jif-google, 2014-05-26 15:34:31]

ptal

[blundell, 2014-05-26 15:53:07]

LGTM

Can you add to the CL description a little context about the long-term state
that this is moving toward (with ChromeFaviconClient being a KeyedService)?

https://codereview.chromium.org/303453004/diff/20001/chrome/browser/favicon/c...
File chrome/browser/favicon/chrome_favicon_client.h (right):

https://codereview.chromium.org/303453004/diff/20001/chrome/browser/favicon/c...
chrome/browser/favicon/chrome_favicon_client.h:16: class ChromeFaviconClient :
public FaviconClient {
Should have a class comment.

https://codereview.chromium.org/303453004/diff/20001/chrome/browser/favicon/f...
File chrome/browser/favicon/favicon_tab_helper.h (right):

https://codereview.chromium.org/303453004/diff/20001/chrome/browser/favicon/f...
chrome/browser/favicon/favicon_tab_helper.h:110: scoped_ptr<FaviconClient>
faviconClient_;
nit: Can just be |client_|.

[jif-google, 2014-05-26 17:49:22]

https://codereview.chromium.org/303453004/diff/20001/chrome/browser/favicon/c...
File chrome/browser/favicon/chrome_favicon_client.h (right):

https://codereview.chromium.org/303453004/diff/20001/chrome/browser/favicon/c...
chrome/browser/favicon/chrome_favicon_client.h:16: class ChromeFaviconClient :
public FaviconClient {
On 2014/05/26 15:53:07, blundell wrote:
> Should have a class comment.

Done.

https://codereview.chromium.org/303453004/diff/20001/chrome/browser/favicon/f...
File chrome/browser/favicon/favicon_tab_helper.h (right):

https://codereview.chromium.org/303453004/diff/20001/chrome/browser/favicon/f...
chrome/browser/favicon/favicon_tab_helper.h:110: scoped_ptr<FaviconClient>
faviconClient_;
On 2014/05/26 15:53:07, blundell wrote:
> nit: Can just be |client_|.

Done.

[jif-google, 2014-05-26 17:49:28]

The CQ bit was checked by jif@google.com

[commit-bot: I haz the power, 2014-05-26 17:49:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/303453004/40001

[commit-bot: I haz the power, 2014-05-26 20:33:53]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-27 00:10:44]

Change committed as 272896