Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1776)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 303453004: Move the FaviconClient implementation to ChromeFaviconClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/chrome_favicon_client.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_tab_helper.h
diff --git a/chrome/browser/favicon/favicon_tab_helper.h b/chrome/browser/favicon/favicon_tab_helper.h
index b1df49777bad598ecb2c8e4a400231a7b4437582..e6a66ad926790819fbea0ad4b0fc49f79be10711 100644
--- a/chrome/browser/favicon/favicon_tab_helper.h
+++ b/chrome/browser/favicon/favicon_tab_helper.h
@@ -35,7 +35,6 @@ class SkBitmap;
// downloaded and saved in the history backend.
//
class FaviconTabHelper : public content::WebContentsObserver,
- public FaviconClient,
public FaviconDriver,
public content::WebContentsUserData<FaviconTabHelper> {
public:
@@ -91,10 +90,6 @@ class FaviconTabHelper : public content::WebContentsObserver,
const std::vector<SkBitmap>& bitmaps,
const std::vector<gfx::Size>& original_bitmap_sizes);
- // FaviconClient implementation:
- virtual FaviconService* GetFaviconService() OVERRIDE;
- virtual bool IsBookmarked(const GURL& url) OVERRIDE;
-
private:
explicit FaviconTabHelper(content::WebContents* web_contents);
friend class content::WebContentsUserData<FaviconTabHelper>;
@@ -112,6 +107,8 @@ class FaviconTabHelper : public content::WebContentsObserver,
Profile* profile_;
+ scoped_ptr<FaviconClient> client_;
+
std::vector<content::FaviconURL> favicon_urls_;
scoped_ptr<FaviconHandler> favicon_handler_;
« no previous file with comments | « chrome/browser/favicon/chrome_favicon_client.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698