Issue 303393005: Disable BrowserFocusTest.FocusTraversalOnInterstitial

Issue 303393005: Disable BrowserFocusTest.FocusTraversalOnInterstitial (Closed)

Created:
6 years, 6 months ago by Michael van Ouwerkerk

Modified:
6 years, 6 months ago

Reviewers:
battre

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Disable BrowserFocusTest.FocusTraversalOnInterstitial BUG=60973 NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274238

Patch Set 2 : Retain reference to old bug. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -11 lines)			Patch
	M	chrome/browser/ui/browser_focus_uitest.cc	View	1	1 chunk	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

battre

https://codereview.chromium.org/303393005/diff/1/chrome/browser/ui/browser_focus_uitest.cc File chrome/browser/ui/browser_focus_uitest.cc (left): https://codereview.chromium.org/303393005/diff/1/chrome/browser/ui/browser_focus_uitest.cc#oldcode437 chrome/browser/ui/browser_focus_uitest.cc:437: // the 1st and 3rd+ Tab key presses seem ...

6 years, 6 months ago (2014-06-02 14:34:04 UTC) #2

Michael van Ouwerkerk

PTAL https://codereview.chromium.org/303393005/diff/1/chrome/browser/ui/browser_focus_uitest.cc File chrome/browser/ui/browser_focus_uitest.cc (left): https://codereview.chromium.org/303393005/diff/1/chrome/browser/ui/browser_focus_uitest.cc#oldcode437 chrome/browser/ui/browser_focus_uitest.cc:437: // the 1st and 3rd+ Tab key presses ...

6 years, 6 months ago (2014-06-02 14:42:46 UTC) #3

Michael van Ouwerkerk

The CQ bit was checked by mvanouwerkerk@chromium.org

6 years, 6 months ago (2014-06-02 14:51:13 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/303393005/10002

6 years, 6 months ago (2014-06-02 14:52:03 UTC) #6

msw

On 2014/06/02 14:53:33, I haz the power (commit-bot) wrote: > Change committed as 274238 Why ...

6 years, 6 months ago (2014-06-02 18:20:22 UTC) #8

msw

6 years, 6 months ago (2014-06-02 18:25:18 UTC) #9

Message was sent while issue was closed.

On 2014/06/02 18:20:22, msw wrote:
> On 2014/06/02 14:53:33, I haz the power (commit-bot) wrote:
> > Change committed as 274238
> 
> Why was this disabled? You didn't cite any reason for doing so (faulure logs,
> etc.) or plans to fix the test. This is why we wind up with files full of
> disabled tests :(

Ah, you posted the bot names on the bug...

Expand Messages | Collapse Messages