Disable BrowserFocusTest.FocusTraversalOnInterstitial

chrome/browser/ui/browser_focus_uitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/format_macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
@@ skipping 412 matching lines @@
   const GURL url = embedded_test_server()->GetURL(kTypicalPage);
   ui_test_utils::NavigateToURL(browser(), url);
   EXPECT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
   chrome::FocusLocationBar(browser());
 
   WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_NO_FATAL_FAILURE(TestFocusTraversal(tab->GetRenderViewHost(), false));
   EXPECT_NO_FATAL_FAILURE(TestFocusTraversal(tab->GetRenderViewHost(), true));
 }
 
-#if defined(OS_MACOSX)
-// TODO(msw): Mac's details wrongly claim that the "textEdit" is not editable on
-// the 2nd forwards traveral loop (but is correct in the 1st loop). Mac also
-// doesn't advance focus on the 2nd reverse Tab press (gmapLink->gmailLink), but
-// the 1st and 3rd+ Tab key presses seem to work. http://crbug.com/60973

[battre, 2014/06/02 14:34:04]

Any reason for adding a new bug number instead of keeping this one and its
history?

[Michael van Ouwerkerk, 2014/06/02 14:42:46]

Ok I kept the old bug reference.

-#define MAYBE_FocusTraversalOnInterstitial DISABLED_FocusTraversalOnInterstitial
-#else
-#define MAYBE_FocusTraversalOnInterstitial FocusTraversalOnInterstitial
-#endif
-
 // Test forward and reverse focus traversal while an interstitial is showing.
-IN_PROC_BROWSER_TEST_F(BrowserFocusTest, MAYBE_FocusTraversalOnInterstitial) {
+// Disabled, see http://crbug.com/379762
+IN_PROC_BROWSER_TEST_F(BrowserFocusTest, DISABLED_FocusTraversalOnInterstitial) {
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   const GURL url = embedded_test_server()->GetURL(kSimplePage);
   ui_test_utils::NavigateToURL(browser(), url);
   EXPECT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
 
   // Create and show a test interstitial page.
   TestInterstitialPage* interstitial_page = new TestInterstitialPage(
       browser()->tab_strip_model()->GetActiveWebContents());
   content::RenderViewHost* host = interstitial_page->render_view_host();
 
@@ skipping 244 matching lines @@
         content::NOTIFICATION_NAV_ENTRY_COMMITTED,
         content::NotificationService::AllSources());
     chrome::GoForward(browser(), CURRENT_TAB);
     forward_nav_observer.Wait();
   }
 
   EXPECT_FALSE(IsViewFocused(VIEW_ID_OMNIBOX));
 }
 
 }  // namespace