rebaseline_server: download actual-results.json files from Google Storage, not skia-autogen

rebaseline_server: download actual-results.json files from Google Storage, not skia-autogen

BUG=skia:553

[epoger, 2014-05-29 21:19:57]

Ravi- PTAL at patchset 1.

I don't think this is "ready for prime time" due to the problem noted below. 
But it does work...

https://codereview.chromium.org/303223006/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/303223006/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:278: # EPOGER: what if the user does not have
gsutil installed in her $PATH?
Any thoughts on what to do about this?

I had originally intended to download the JSON files via HTTP (like how we
download the images).  The problem: I am not aware of a simple way to download a
whole directory full of files via HTTP.  You have to know the exact filenames
you are looking for, and download each one by its full URL.

Maybe there is some way to download all of gs://chromium-skia-gm-summaries via
HTTP?

Or maybe we should add gsutil to our DEPS?

[rmistry, 2014-05-30 14:15:28]

https://codereview.chromium.org/303223006/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/303223006/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:71: DEFAULT_ACTUALS_GS_ROOT =
'gs://chromium-skia-gm-summaries'
Should we add this to global_variables.json? I believe gs://chromium-skia-gm is
there as well.

https://codereview.chromium.org/303223006/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:196: actuals_dir: directory into which we will
download the latest actual
[optional] since we are not going to be dealing with remove GS directories as
well should we should specifying "local" to differenciate (atleast in the param
description):

actuals_dir: local directory into which we will download the latest actual GM
results

https://codereview.chromium.org/303223006/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:278: # EPOGER: what if the user does not have
gsutil installed in her $PATH?
On 2014/05/29 21:19:57, epoger wrote:
> Any thoughts on what to do about this?

Maybe add a check at the top to make sure that there is a gsutil in the PATH, if
not then we can echo instructions on downloading and setting up gsutil.
Also, having gsutil in PATH will not garantee that appropriate permissions
exist, might want to do a basic check after finding gsutil in PATH to ensure
that the right credentials / permissions exist.

> 
> I had originally intended to download the JSON files via HTTP (like how we
> download the images).  The problem: I am not aware of a simple way to download
a
> whole directory full of files via HTTP.  You have to know the exact filenames
> you are looking for, and download each one by its full URL.
> 
> Maybe there is some way to download all of gs://chromium-skia-gm-summaries via
> HTTP?

No idea about this. But I am not surprised that there is no way to download a
folder via HTTP.

> 
> Or maybe we should add gsutil to our DEPS?

Even if we did this the user would still need an appropriate .boto file or would
need to be authenticated via gsutil.

[rmistry, 2014-05-30 14:16:27]

https://codereview.chromium.org/303223006/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/303223006/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:196: actuals_dir: directory into which we will
download the latest actual
On 2014/05/30 14:15:28, rmistry wrote:
> [optional] since we are not going to be dealing with remove GS directories as
> well should we should specifying "local" to differenciate (atleast in the
param
> description):
> 
> actuals_dir: local directory into which we will download the latest actual GM
> results

So many typos:
"since we are going to be dealing with remote GS directories as well"

[epoger, 2014-06-03 20:12:26]

closing in favor of https://codereview.chromium.org/310093003/
('rebaseline_server: download actual-results.json files from GCS instead of
SVN')