Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Unified Diff: mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc

Issue 303163005: Embedding demo in View manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
diff --git a/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc b/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
index f4430c941078540b4d5af930fcdc45b05cffa627..90bbb6c0ef2528e57b223368703a3f157c8fbfa5 100644
--- a/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
+++ b/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
@@ -258,8 +258,8 @@ class ViewManagerTest : public testing::Test {
ViewManagerTest() : commit_count_(0) {}
protected:
- ViewManager* view_manager_1() { return view_manager_1_.get(); }
- ViewManager* view_manager_2() { return view_manager_2_.get(); }
+ ViewManager* view_manager_1() { return view_manager_1_; }
+ ViewManager* view_manager_2() { return view_manager_2_; }
ViewTreeNode* CreateNodeInParent(ViewTreeNode* parent) {
ViewManager* parent_manager = ViewTreeNodePrivate(parent).view_manager();
@@ -269,23 +269,19 @@ class ViewManagerTest : public testing::Test {
}
void DestroyViewManager1() {
- view_manager_1_.reset();
+ // view_manager_1_.reset();
}
private:
// Overridden from testing::Test:
virtual void SetUp() OVERRIDE {
test_helper_.Init();
- view_manager_1_.reset(new ViewManager(test_helper_.service_provider()));
- view_manager_2_.reset(new ViewManager(test_helper_.service_provider()));
- view_manager_1_->Init();
- view_manager_2_->Init();
}
base::MessageLoop loop_;
shell::ShellTestHelper test_helper_;
- scoped_ptr<ViewManager> view_manager_1_;
- scoped_ptr<ViewManager> view_manager_2_;
+ ViewManager* view_manager_1_;
+ ViewManager* view_manager_2_;
int commit_count_;
DISALLOW_COPY_AND_ASSIGN(ViewManagerTest);
« no previous file with comments | « mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc ('k') | mojo/services/public/cpp/view_manager/view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698