ash: Fix VideoDetectorTest's WindowState usage.

ash: Fix VideoDetectorTest's WindowState usage.

Make the VideoDetector FullscreenWindow test use
GetWindowState() to access WindowState objects. Otherwise,
the WindowStates don't get unregistered as WindowObservers
when they're destroyed. This was responsible for the test
crashes that resulted in r266681 being reverted.

BUG=365364
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273783

[oshima, 2014-05-29 23:51:16]

The real issue is that the test is not using GetWindowState().

The window state object is designed to be owned by window and deleted in the
window's dtor, so this shouldn't be necessary.

[Daniel Erat, 2014-05-30 00:53:21]

thanks for the explanation! i didn't realize that Window's d'tor already
unregistered all of its observers before destroying its properties. please take
another look.

[oshima, 2014-05-30 00:56:36]

lgtm+

[Daniel Erat, 2014-05-30 00:56:59]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-05-30 00:58:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/derat@chromium.org/303163003/10001

[sky, 2014-05-30 02:29:13]

https://codereview.chromium.org/303163003/diff/10001/ash/wm/window_state.cc
File ash/wm/window_state.cc (right):

https://codereview.chromium.org/303163003/diff/10001/ash/wm/window_state.cc#n...
ash/wm/window_state.cc:101: WindowState::~WindowState() {
Is it possible to make this private and friend some class?

[sky, 2014-05-30 02:29:28]

I'm LGTMing, the private friend can happen separately.

[commit-bot: I haz the power, 2014-05-30 10:16:23]

Change committed as 273783