Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2898)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/wm/window_state.cc

Issue 303163003: ash: Fix VideoDetectorTest's WindowState usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test instead Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/video_detector_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/window_state.cc
diff --git a/ash/wm/window_state.cc b/ash/wm/window_state.cc
index 7c5c1674f14b050f4593608c1fa278d72e571221..0b2e674f9596a7c3a73932acc5f84b5beb8d1132 100644
--- a/ash/wm/window_state.cc
+++ b/ash/wm/window_state.cc
@@ -99,6 +99,10 @@ WindowState::WindowState(aura::Window* window)
}
WindowState::~WindowState() {
sky 2014/05/30 02:29:13 Is it possible to make this private and friend som
+ // WindowState is registered as an owned property of |window_|, and window
+ // unregisters all of its observers in its d'tor before destroying its
+ // properties. As a result, window_->RemoveObserver() doesn't need to (and
+ // shouldn't) be called here.
}
bool WindowState::HasDelegate() const {
« no previous file with comments | « ash/wm/video_detector_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698