Issue 303113002: Correctly handle object classname and add Symbol type to PropertyPreview and CallArgument in the pr…

Issue 303113002: Correctly handle object classname and add Symbol type to PropertyPreview and CallArgument in the pr… (Closed)

Created:
6 years, 6 months ago by Alexandra Mikhaylova

Modified:
6 years, 6 months ago

Reviewers:
aandrey, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Correctly handle object classname and add Symbol type to PropertyPreview and CallArgument in the protocol. BUG=376194 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175082

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	Source/core/inspector/InjectedScriptSource.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	Source/devtools/protocol.json	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

aandrey

lgtm https://codereview.chromium.org/303113002/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/303113002/diff/1/Source/devtools/protocol.json#newcode690 Source/devtools/protocol.json:690: { "name": "type", "type": "string", "enum": ["object", "function", ...

6 years, 6 months ago (2014-05-29 13:58:11 UTC) #2

Alexandra Mikhaylova

https://codereview.chromium.org/303113002/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/303113002/diff/1/Source/devtools/protocol.json#newcode690 Source/devtools/protocol.json:690: { "name": "type", "type": "string", "enum": ["object", "function", "undefined", ...

6 years, 6 months ago (2014-05-29 14:02:19 UTC) #3

Alexandra Mikhaylova

The CQ bit was checked by amikhaylova@google.com

6 years, 6 months ago (2014-05-29 15:30:07 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amikhaylova@google.com/303113002/20001

6 years, 6 months ago (2014-05-29 15:30:52 UTC) #6

Message was sent while issue was closed.

Change committed as 175082

Expand Messages | Collapse Messages