Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: Source/devtools/protocol.json

Issue 303113002: Correctly handle object classname and add Symbol type to PropertyPreview and CallArgument in the pr… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/inspector/InjectedScriptSource.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 "version": { "major": "1", "minor": "1" }, 2 "version": { "major": "1", "minor": "1" },
3 "domains": [{ 3 "domains": [{
4 "domain": "Inspector", 4 "domain": "Inspector",
5 "hidden": true, 5 "hidden": true,
6 "types": [], 6 "types": [],
7 "commands": [ 7 "commands": [
8 { 8 {
9 "name": "enable", 9 "name": "enable",
10 "description": "Enables inspector domain notifications." 10 "description": "Enables inspector domain notifications."
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 { "name": "overflow", "type": "boolean", "description": "Tru e iff some of the properties of the original did not fit." }, 680 { "name": "overflow", "type": "boolean", "description": "Tru e iff some of the properties of the original did not fit." },
681 { "name": "properties", "type": "array", "items": { "$ref": "PropertyPreview" }, "description": "List of the properties." } 681 { "name": "properties", "type": "array", "items": { "$ref": "PropertyPreview" }, "description": "List of the properties." }
682 ] 682 ]
683 }, 683 },
684 { 684 {
685 "id": "PropertyPreview", 685 "id": "PropertyPreview",
686 "type": "object", 686 "type": "object",
687 "hidden": true, 687 "hidden": true,
688 "properties": [ 688 "properties": [
689 { "name": "name", "type": "string", "description": "Property name." }, 689 { "name": "name", "type": "string", "description": "Property name." },
690 » { "name": "type", "type": "string", "enum": ["object", " function", "undefined", "string", "number", "boolean", "accessor"], "description ": "Object type. Accessor means that the property itself is an accessor property ." }, 690 { "name": "type", "type": "string", "enum": ["object", "func tion", "undefined", "string", "number", "boolean", "symbol", "accessor"], "descr iption": "Object type. Accessor means that the property itself is an accessor pr operty." },
691 » { "name": "value", "type": "string", "optional": true, " description": "User-friendly property value string." }, 691 { "name": "value", "type": "string", "optional": true, "desc ription": "User-friendly property value string." },
692 » { "name": "valuePreview", "$ref": "ObjectPreview", "opti onal": true, "description": "Nested value preview." }, 692 { "name": "valuePreview", "$ref": "ObjectPreview", "optional ": true, "description": "Nested value preview." },
693 » { "name": "subtype", "type": "string", "optional": true, "enum": ["array", "null", "node", "regexp", "date"], "description": "Object sub type hint. Specified for <code>object</code> type values only." } 693 { "name": "subtype", "type": "string", "optional": true, "en um": ["array", "null", "node", "regexp", "date"], "description": "Object subtype hint. Specified for <code>object</code> type values only." }
694 ] 694 ]
695 }, 695 },
696 { 696 {
697 "id": "PropertyDescriptor", 697 "id": "PropertyDescriptor",
698 "type": "object", 698 "type": "object",
699 "description": "Object property descriptor.", 699 "description": "Object property descriptor.",
700 "properties": [ 700 "properties": [
701 { "name": "name", "type": "string", "description": "Property name." }, 701 { "name": "name", "type": "string", "description": "Property name." },
702 { "name": "value", "$ref": "RemoteObject", "optional": true, "description": "The value associated with the property." }, 702 { "name": "value", "$ref": "RemoteObject", "optional": true, "description": "The value associated with the property." },
703 { "name": "writable", "type": "boolean", "optional": true, " description": "True if the value associated with the property may be changed (da ta descriptors only)." }, 703 { "name": "writable", "type": "boolean", "optional": true, " description": "True if the value associated with the property may be changed (da ta descriptors only)." },
(...skipping 16 matching lines...) Expand all
720 ], 720 ],
721 "hidden": true 721 "hidden": true
722 }, 722 },
723 { 723 {
724 "id": "CallArgument", 724 "id": "CallArgument",
725 "type": "object", 725 "type": "object",
726 "description": "Represents function call argument. Either remote object id <code>objectId</code> or primitive <code>value</code> or neither of ( for undefined) them should be specified.", 726 "description": "Represents function call argument. Either remote object id <code>objectId</code> or primitive <code>value</code> or neither of ( for undefined) them should be specified.",
727 "properties": [ 727 "properties": [
728 { "name": "value", "type": "any", "optional": true, "descrip tion": "Primitive value, or description string if the value can not be JSON-stri ngified (like NaN, Infinity, -Infinity, -0)." }, 728 { "name": "value", "type": "any", "optional": true, "descrip tion": "Primitive value, or description string if the value can not be JSON-stri ngified (like NaN, Infinity, -Infinity, -0)." },
729 { "name": "objectId", "$ref": "RemoteObjectId", "optional": true, "description": "Remote object handle." }, 729 { "name": "objectId", "$ref": "RemoteObjectId", "optional": true, "description": "Remote object handle." },
730 { "name": "type", "optional": true, "hidden": true, "type": "string", "enum": ["object", "function", "undefined", "string", "number", "boole an"], "description": "Object type." } 730 { "name": "type", "optional": true, "hidden": true, "type": "string", "enum": ["object", "function", "undefined", "string", "number", "boole an", "symbol"], "description": "Object type." }
731 ] 731 ]
732 }, 732 },
733 { 733 {
734 "id": "ExecutionContextId", 734 "id": "ExecutionContextId",
735 "type": "integer", 735 "type": "integer",
736 "description": "Id of an execution context." 736 "description": "Id of an execution context."
737 }, 737 },
738 { 738 {
739 "id": "ExecutionContextDescription", 739 "id": "ExecutionContextDescription",
740 "type": "object", 740 "type": "object",
(...skipping 3404 matching lines...) Expand 10 before | Expand all | Expand 10 after
4145 { 4145 {
4146 "name": "dataAvailable", 4146 "name": "dataAvailable",
4147 "parameters": [ 4147 "parameters": [
4148 {"name": "value", "type": "array", "items": { "$ref": "Power Event" }, "description": "List of power events." } 4148 {"name": "value", "type": "array", "items": { "$ref": "Power Event" }, "description": "List of power events." }
4149 ], 4149 ],
4150 "handlers": ["browser", "frontend"] 4150 "handlers": ["browser", "frontend"]
4151 } 4151 }
4152 ] 4152 ]
4153 }] 4153 }]
4154 } 4154 }
OLDNEW
« no previous file with comments | « Source/core/inspector/InjectedScriptSource.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698