Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 302923003: stop calling deprecated asImageInfo (Closed)

Created:
6 years, 6 months ago by reed2
Modified:
6 years, 6 months ago
Reviewers:
pdr., f(malita), reed1
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

stop calling deprecated asImageInfo BUG=

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M Source/platform/graphics/DiscardablePixelRef.cpp View 1 chunk +2 lines, -2 lines 2 comments Download
M Source/platform/graphics/ImageFrameGenerator.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/test/MockDiscardablePixelRef.h View 1 chunk +2 lines, -3 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
reed2
6 years, 6 months ago (2014-05-29 02:22:33 UTC) #1
pdr.
https://codereview.chromium.org/302923003/diff/1/Source/platform/graphics/DiscardablePixelRef.cpp File Source/platform/graphics/DiscardablePixelRef.cpp (right): https://codereview.chromium.org/302923003/diff/1/Source/platform/graphics/DiscardablePixelRef.cpp#newcode52 Source/platform/graphics/DiscardablePixelRef.cpp:52: if (kUnknown_SkColorType == info.colorType()) Are these colorType checks just ...
6 years, 6 months ago (2014-05-29 04:52:14 UTC) #2
reed1
https://codereview.chromium.org/302923003/diff/1/Source/platform/graphics/DiscardablePixelRef.cpp File Source/platform/graphics/DiscardablePixelRef.cpp (right): https://codereview.chromium.org/302923003/diff/1/Source/platform/graphics/DiscardablePixelRef.cpp#newcode52 Source/platform/graphics/DiscardablePixelRef.cpp:52: if (kUnknown_SkColorType == info.colorType()) On 2014/05/29 04:52:14, pdr wrote: ...
6 years, 6 months ago (2014-05-29 12:10:57 UTC) #3
f(malita)
lgtm https://codereview.chromium.org/302923003/diff/1/Source/platform/graphics/test/MockDiscardablePixelRef.h File Source/platform/graphics/test/MockDiscardablePixelRef.h (right): https://codereview.chromium.org/302923003/diff/1/Source/platform/graphics/test/MockDiscardablePixelRef.h#newcode54 Source/platform/graphics/test/MockDiscardablePixelRef.h:54: const SkImageInfo info = dst->info(); const SkImageInfo&
6 years, 6 months ago (2014-05-29 12:51:38 UTC) #4
reed1
6 years, 6 months ago (2014-05-29 13:14:14 UTC) #5 
closing in favor of https://codereview.chromium.org/307813004/ (which I can
edit)

Powered by Google App Engine
This is Rietveld 408576698