stop calling deprecated asImageInfo

Source/platform/graphics/DiscardablePixelRef.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 30 matching lines @@
 
 bool DiscardablePixelRefAllocator::allocPixelRef(SkBitmap* dst, SkColorTable* ctable)
 {
     // It should not be possible to have a non-null color table in Blink.
     ASSERT(!ctable);
 
     int64_t size = dst->computeSize64();
     if (size < 0 || !sk_64_isS32(size))
         return false;
 
-    SkImageInfo info;
-    if (!dst->asImageInfo(&info))
+    const SkImageInfo& info = dst->info();
+    if (kUnknown_SkColorType == info.colorType())

[pdr., 2014/05/29 04:52:14]

Are these colorType checks just checking if the SkImageInfo is valid? If so,
could we add something more explicit to the SkImageInfo api so it's more
understandable?

[reed1, 2014/05/29 12:10:57]

Not really a question of valid. kUnknown is valid for some uses, it just isn't
supported by a pixelallocator. This is the same predicate as the old asImageInfo
performed.

         return false;
 
     SkAutoTUnref<DiscardablePixelRef> pixelRef(new DiscardablePixelRef(info, dst->rowBytes(), adoptPtr(new SkMutex())));
     if (pixelRef->allocAndLockDiscardableMemory(sk_64_asS32(size))) {
         pixelRef->setURI(labelDiscardable);
         dst->setPixelRef(pixelRef.get());
         // This method is only called when a DiscardablePixelRef is created to back a SkBitmap.
         // It is necessary to lock this SkBitmap to have a valid pointer to pixels. Otherwise,
         // this SkBitmap could be assigned to another SkBitmap and locking/unlocking the other
         // SkBitmap will make this one losing its pixels.
@@ skipping 47 matching lines @@
         m_discardable->unlock();
     m_lockedMemory = 0;
 }
 
 bool DiscardablePixelRef::isDiscardable(SkPixelRef* pixelRef)
 {
     return pixelRef && pixelRef->getURI() && !strcmp(pixelRef->getURI(), labelDiscardable);
 }
 
 } // namespace WebCore