Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 302863004: libvpx: Manually set output dir of gen asm offsets libs. (Closed)

Created:
6 years, 6 months ago by fgalligan
Modified:
6 years, 6 months ago
Reviewers:
fgalligan1, Tom Finegan
CC:
chromium-reviews, wwcv, jzern, fgalligan1, Torne
Visibility:
Public.

Description

libvpx: Manually set output dir of gen asm offsets libs. Force libvpx_asm_offsets_vp8.a and libvpx_asm_offsets_vpx_scale.a to be built in "shared_generated_dir". BUG=377062 TBR=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M libvpx.gyp View 6 chunks +4 lines, -16 lines 0 comments Download
M unpack_lib_posix.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
fgalligan1
6 years, 6 months ago (2014-05-28 18:53:00 UTC) #1
fgalligan
Committed patchset #1 manually as r273304 (presubmit successful).
6 years, 6 months ago (2014-05-28 18:53:40 UTC) #2
fgalligan1
6 years, 6 months ago (2014-05-28 19:36:46 UTC) #3
Tom Finegan
6 years, 6 months ago (2014-05-30 15:51:56 UTC) #4
Message was sent while issue was closed.
On 2014/05/28 19:36:46, fgalligan1 wrote:

lgtm

Powered by Google App Engine
This is Rietveld 408576698