Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 302743002: Cleanup: Remove the remaining instance of ChromiumTestShell from Telemetry scripts. (Closed)

Created:
6 years, 7 months ago by r.kasibhatla
Modified:
6 years, 6 months ago
Reviewers:
cmp, Dirk Pranke
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Cleanup: Remove the remaining instance of ChromiumTestShell from Telemetry scripts. This CL is along with https://crrev.com/302653004 in which we are removing remaining instances of ChromiumTestShell and replacing it with ChromeShell. This CL updates the corresponding scripts in build bot which invokes telemetry scripts using the ChromiumTestShell notation. BUG=None TBR=dpranke@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=276351

Patch Set 1 #

Patch Set 2 : Corrected the .expected file to resolve test failures! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M scripts/slave/telemetry.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/unittests/telemetry_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/data/trymail_tests/android.expected View 1 1 chunk +15 lines, -15 lines 0 comments Download
M tests/data/trymail_tests/android.in View 1 chunk +1 line, -1 line 0 comments Download
M tests/data/trymail_tests/android_failure.expected View 1 1 chunk +15 lines, -15 lines 0 comments Download
M tests/data/trymail_tests/android_failure.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
r.kasibhatla
PTAL.
6 years, 7 months ago (2014-05-27 13:38:49 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-05-28 19:06:52 UTC) #2
r.kasibhatla
On 2014/05/28 19:06:52, Dirk Pranke wrote: > lgtm Dirk, What is the order of commit ...
6 years, 6 months ago (2014-05-30 05:47:56 UTC) #3
Dirk Pranke
On 2014/05/30 05:47:56, r.kasibhatla wrote: > On 2014/05/28 19:06:52, Dirk Pranke wrote: > > lgtm ...
6 years, 6 months ago (2014-05-30 18:54:12 UTC) #4
r.kasibhatla
> Neither way will work flawlessly :(. > > You probably need to do this ...
6 years, 6 months ago (2014-06-02 12:01:52 UTC) #5
r.kasibhatla
The CQ bit was checked by r.kasibhatla@samsung.com
6 years, 6 months ago (2014-06-06 04:15:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/302743002/1
6 years, 6 months ago (2014-06-06 04:15:48 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 04:16:36 UTC) #8
commit-bot: I haz the power
Presubmit check for 302743002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-06 04:16:37 UTC) #9
r.kasibhatla
> ** Presubmit ERRORS ** > tests/tryserver_mail_test.py (3.55s) failed > FAIL: test_android (__main__.TestMailNotifier) @dpranke: How ...
6 years, 6 months ago (2014-06-06 07:03:28 UTC) #10
r.kasibhatla
On 2014/06/06 07:03:28, r.kasibhatla wrote: > > ** Presubmit ERRORS ** > > tests/tryserver_mail_test.py (3.55s) ...
6 years, 6 months ago (2014-06-09 04:56:58 UTC) #11
Dirk Pranke
On 2014/06/09 04:56:58, r.kasibhatla wrote: > On 2014/06/06 07:03:28, r.kasibhatla wrote: > > > ** ...
6 years, 6 months ago (2014-06-09 19:59:45 UTC) #12
r.kasibhatla
The CQ bit was checked by r.kasibhatla@samsung.com
6 years, 6 months ago (2014-06-11 11:34:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/302743002/20001
6 years, 6 months ago (2014-06-11 11:35:13 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 11:36:43 UTC) #15
Message was sent while issue was closed. 
Change committed as 276351

Powered by Google App Engine
This is Rietveld 408576698