Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: public/platform/Platform.h

Issue 302703003: lockOrientation() fallback when the callback one isn't implemented. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix fixme Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/Platform.h
diff --git a/public/platform/Platform.h b/public/platform/Platform.h
index 8719bbd054a1fe29065cd74af81621532a6a02a1..de277ac4f00ad928866f4ef2b49520afa39a3015 100644
--- a/public/platform/Platform.h
+++ b/public/platform/Platform.h
@@ -639,8 +639,12 @@ public:
// Request a screen orientation lock and pass a |callback| object to be used
// to notify of success/failure. The |callback| parameter is expected to be
// owned by the implementation.
- virtual void lockOrientation(WebScreenOrientationLockType, WebLockOrientationCallback* callback)
+ virtual void lockOrientation(WebScreenOrientationLockType orientation, WebLockOrientationCallback* callback)
{
+ // FIXME: remove this when
+ // lockOrientation(orientation, callback) will be handled in Chromium.
+ lockOrientation(orientation);
+
delete callback; // prevents memory leak if there is no implementation.
}
virtual void unlockOrientation() { }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698