Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: public/platform/Platform.h

Issue 302703003: lockOrientation() fallback when the callback one isn't implemented. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix fixme Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 621 matching lines...) Expand 10 before | Expand all | Expand 10 after
632 virtual void setDeviceLightListener(blink::WebDeviceLightListener*) { } 632 virtual void setDeviceLightListener(blink::WebDeviceLightListener*) { }
633 633
634 634
635 // Screen Orientation ------------------------------------------------- 635 // Screen Orientation -------------------------------------------------
636 636
637 virtual void setScreenOrientationListener(blink::WebScreenOrientationListene r*) { } 637 virtual void setScreenOrientationListener(blink::WebScreenOrientationListene r*) { }
638 virtual void lockOrientation(WebScreenOrientationLockType) { } 638 virtual void lockOrientation(WebScreenOrientationLockType) { }
639 // Request a screen orientation lock and pass a |callback| object to be used 639 // Request a screen orientation lock and pass a |callback| object to be used
640 // to notify of success/failure. The |callback| parameter is expected to be 640 // to notify of success/failure. The |callback| parameter is expected to be
641 // owned by the implementation. 641 // owned by the implementation.
642 virtual void lockOrientation(WebScreenOrientationLockType, WebLockOrientatio nCallback* callback) 642 virtual void lockOrientation(WebScreenOrientationLockType orientation, WebLo ckOrientationCallback* callback)
643 { 643 {
644 // FIXME: remove this when
645 // lockOrientation(orientation, callback) will be handled in Chromium.
646 lockOrientation(orientation);
647
644 delete callback; // prevents memory leak if there is no implementation. 648 delete callback; // prevents memory leak if there is no implementation.
645 } 649 }
646 virtual void unlockOrientation() { } 650 virtual void unlockOrientation() { }
647 651
648 652
649 // Quota ----------------------------------------------------------- 653 // Quota -----------------------------------------------------------
650 654
651 // Queries the storage partition's storage usage and quota information. 655 // Queries the storage partition's storage usage and quota information.
652 // WebStorageQuotaCallbacks::didQueryStorageUsageAndQuota will be called 656 // WebStorageQuotaCallbacks::didQueryStorageUsageAndQuota will be called
653 // with the current usage and quota information for the partition. When 657 // with the current usage and quota information for the partition. When
(...skipping 10 matching lines...) Expand all
664 virtual WebDatabaseObserver* databaseObserver() { return 0; } 668 virtual WebDatabaseObserver* databaseObserver() { return 0; }
665 669
666 670
667 protected: 671 protected:
668 virtual ~Platform() { } 672 virtual ~Platform() { }
669 }; 673 };
670 674
671 } // namespace blink 675 } // namespace blink
672 676
673 #endif 677 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698