Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 302703003: lockOrientation() fallback when the callback one isn't implemented. (Closed)

Created:
6 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

lockOrientation() fallback when the callback one isn't implemented. Required to keep chromium working until it handles the callback method. BUG=162827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175128

Patch Set 1 #

Patch Set 2 : fix fixme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M public/platform/Platform.h View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 30 (0 generated)
mlamouri (slow - plz ping)
6 years, 7 months ago (2014-05-27 13:14:13 UTC) #1
jochen (gone - plz use gerrit)
we usually don't put the ldap in the FIXME in blink, just // FIXME: lgtm
6 years, 7 months ago (2014-05-27 13:16:44 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 7 months ago (2014-05-27 13:19:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/302703003/20001
6 years, 7 months ago (2014-05-27 13:19:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 14:51:41 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 14:51:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/10877)
6 years, 7 months ago (2014-05-27 14:51:57 UTC) #7
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-28 19:06:35 UTC) #8
mlamouri (slow - plz ping)
The CQ bit was unchecked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-28 19:06:42 UTC) #9
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-29 11:42:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/302703003/20001
6 years, 6 months ago (2014-05-29 11:43:30 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-29 12:55:50 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 13:48:41 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9278)
6 years, 6 months ago (2014-05-29 13:48:41 UTC) #14
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-29 14:46:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/302703003/20001
6 years, 6 months ago (2014-05-29 14:48:01 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-29 15:34:14 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 16:18:49 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9278)
6 years, 6 months ago (2014-05-29 16:18:50 UTC) #19
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-29 16:24:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/302703003/20001
6 years, 6 months ago (2014-05-29 16:25:51 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-29 17:20:41 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 18:34:24 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9278)
6 years, 6 months ago (2014-05-29 18:34:24 UTC) #24
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-30 09:23:38 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/302703003/20001
6 years, 6 months ago (2014-05-30 09:24:47 UTC) #26
mlamouri (slow - plz ping)
The CQ bit was unchecked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-30 09:38:39 UTC) #27
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-30 13:43:06 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/302703003/20001
6 years, 6 months ago (2014-05-30 13:43:26 UTC) #29
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 13:44:29 UTC) #30
Message was sent while issue was closed.
Change committed as 175128

Powered by Google App Engine
This is Rietveld 408576698