Cleanup: Remove the remaining instances of ChromiumTestShell from Telemetry scripts.

Cleanup: Remove the remaining instances of ChromiumTestShell from Telemetry scripts.

Chrome shell is still being referred as ChromiumTestShell in
some places, especially in the telemetry scripts. This
cleanup has dependency on changes in the buildbot
scripts as well where we are invoking the telemetry scripts
as ChromiumTestShell. The buildbot changes are uploaded as
part of https://crrev.com/302743002 to correct invocation as
ChromeShell instead ChromiumTestShell.

BUG=355730
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274857

[r.kasibhatla, 2014-05-27 13:38:42]

PTAL.

[marja, 2014-05-27 13:49:06]

Owners-lgtm for Telemetry (as in, cannot see anything wrong, and tonyg@s FIXME
clearly says this should be done)

[tonyg, 2014-05-27 20:50:11]

lgtm

But we'll need to land a change to
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...
at the same time.

[r.kasibhatla, 2014-05-28 04:38:55]

On 2014/05/27 20:50:11, tonyg wrote:
> lgtm
> 
> But we'll need to land a change to
>
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...
> at the same time.

I have already raised the review request for the repo @
https://codereview.chromium.org/302743002/.
Waiting for review on it. Will commit both changes at same time.

[r.kasibhatla, 2014-05-30 05:48:27]

On 2014/05/28 04:38:55, r.kasibhatla wrote:
> On 2014/05/27 20:50:11, tonyg wrote:
> > lgtm
> > 
> > But we'll need to land a change to
> >
>
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...
> > at the same time.
> 
> I have already raised the review request for the repo @
> https://codereview.chromium.org/302743002/.
> Waiting for review on it. Will commit both changes at same time.

Tonyg,
What is the order of commit for both the concerned CL?
Should I first land the Chromium CL (https://crrev.com/302653004) followed by
this? Or is it vice versa?

[tonyg, 2014-05-30 17:11:47]

On 2014/05/30 05:48:27, r.kasibhatla wrote:
> On 2014/05/28 04:38:55, r.kasibhatla wrote:
> > On 2014/05/27 20:50:11, tonyg wrote:
> > > lgtm
> > > 
> > > But we'll need to land a change to
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...
> > > at the same time.
> > 
> > I have already raised the review request for the repo @
> > https://codereview.chromium.org/302743002/.
> > Waiting for review on it. Will commit both changes at same time.
> 
> Tonyg,
> What is the order of commit for both the concerned CL?
> Should I first land the Chromium CL (https://crrev.com/302653004) followed by
> this? Or is it vice versa?

Either one would break the other. So you might be able to get by with just
landing them both as close to the same time as possible. If that doesn't work,
another option would be to add a temporary hack to Telemetry so that it could
accept both the new and old names. Then once the buildbots are all verified to
be using the new name we could rip out the old.

[r.kasibhatla, 2014-06-02 11:58:24]

As per tonyg and dpranke suggestions, I have readded the nomenclature of
android-chromium-testshell to the list. It will be in addition to the newly
added android-chrome-shell.

Once the buildbot changes go through, then I will remove
android-chromium-testshell completely.

PTAL.

[r.kasibhatla, 2014-06-02 11:59:09]

Modified as per tonyg and dpranke suggestions for landing the patches.

[tonyg, 2014-06-02 15:20:43]

lgtm

https://codereview.chromium.org/302653004/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
(left):

https://codereview.chromium.org/302653004/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:27: #
TODO(tonyg): rename android-chromium-testshell to android-chrome-shell
I guess we should keep a TODO here to remove this entry.

[r.kasibhatla, 2014-06-03 03:24:28]

The CQ bit was checked by r.kasibhatla@samsung.com

[commit-bot: I haz the power, 2014-06-03 03:24:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/302653004/40001

[commit-bot: I haz the power, 2014-06-03 07:36:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-03 07:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 07:40:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[r.kasibhatla, 2014-06-03 09:32:19]

On 2014/06/03 07:40:01, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

@cmp: Can you please review the change? Its waiting for LGTM from OWNERS for
bb_device_steps.py.

[cmp, 2014-06-03 18:46:10]

+navabi

Sure, but I'd like Armand to review this.  I added him to the reviewers list.

[navabi, 2014-06-03 19:11:46]

lgtm for bb_device_steps.py

[r.kasibhatla, 2014-06-04 16:22:19]

The CQ bit was checked by r.kasibhatla@samsung.com

[commit-bot: I haz the power, 2014-06-04 16:23:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/302653004/40001

[commit-bot: I haz the power, 2014-06-04 16:28:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-06-04 16:34:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 16:34:17]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[r.kasibhatla, 2014-06-04 16:46:49]

On 2014/06/04 16:34:17, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

Why is try server still crying about missing LGTM from owner for
bb_device_steps.py, even after lgtm from navabi?

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    build/android/buildbot/bb_device_steps.py

Is it trying to start again the previous cached build? Any way to trigger a
clobber build?

[Dirk Pranke, 2014-06-04 17:26:43]

On 2014/06/04 16:46:49, r.kasibhatla wrote:
> On 2014/06/04 16:34:17, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium
> >
>
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
> 
> Why is try server still crying about missing LGTM from owner for
> bb_device_steps.py, even after lgtm from navabi?
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
>     build/android/buildbot/bb_device_steps.py
> 
> Is it trying to start again the previous cached build? Any way to trigger a
> clobber build?

It looks like navabi@google.com gave the lgtm, but navabi@chromium.org is the
owner. This is an annoyance that crops up from time to time :(.

[cmp, 2014-06-04 17:33:25]

lgtm (since navabi already lgtm'd)

[cmp, 2014-06-04 17:33:31]

The CQ bit was checked by cmp@chromium.org

[commit-bot: I haz the power, 2014-06-04 17:34:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/302653004/40001

[commit-bot: I haz the power, 2014-06-04 17:40:10]

Change committed as 274857