UMA for modifying the profile image/name in the menu.

UMA for modifying the profile image/name in the menu.

BUG=357693
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273407

[Mike Lerman, 2014-05-28 15:32:37]

Hi Hui,

Can you review that these are the logical ways to track changing a name or image
from the user menu? I'll send it out to owners after.

Thanks!
Mike

[guohui, 2014-05-28 18:08:26]

lgtm with one nit.

https://codereview.chromium.org/302603013/diff/1/chrome/browser/ui/views/prof...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/302603013/diff/1/chrome/browser/ui/views/prof...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:780:
PostActionPerformed(ProfileMetrics::PROFILE_DESKTOP_MENU_EDIT_NAME);
nits: the name "PostAction" suggests that it should be called after the action
is performed, so it seems more appropriate to move this line after
profiles::UpdateProfileName.

[Mike Lerman, 2014-05-28 18:11:50]

Thanks, Hui!

Owners, can I get reviews, please?

noms - c/b/profiles
asvitkine - histograms.xml
msw - c/b/ui/views

Thanks!

https://codereview.chromium.org/302603013/diff/1/chrome/browser/ui/views/prof...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/302603013/diff/1/chrome/browser/ui/views/prof...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:780:
PostActionPerformed(ProfileMetrics::PROFILE_DESKTOP_MENU_EDIT_NAME);
On 2014/05/28 18:08:26, guohui wrote:
> nits: the name "PostAction" suggests that it should be called after the action
> is performed, so it seems more appropriate to move this line after
> profiles::UpdateProfileName.

Done.

[noms (inactive), 2014-05-28 18:22:39]

profiles lgtm % nits

https://codereview.chromium.org/302603013/diff/10001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/302603013/diff/10001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:41136: +  <int value="0" label="Locked
In Menu">
nit: 'in' isn't capitalized anywhere else. Also, should it maybe be "Lock in
Menu" instead?

https://codereview.chromium.org/302603013/diff/10001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:41148: +  <int value="4" label="Edit
Profile Image Account in Menu">
nit: why 'profile image account' and not just 'profile image'?

[Mike Lerman, 2014-05-28 18:37:02]

Thanks Monica!

https://codereview.chromium.org/302603013/diff/10001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/302603013/diff/10001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:41136: +  <int value="0" label="Locked
In Menu">
On 2014/05/28 18:22:39, Monica Dinculescu wrote:
> nit: 'in' isn't capitalized anywhere else. Also, should it maybe be "Lock in
> Menu" instead?

That is a very nitty nit. I like it!
Done.

https://codereview.chromium.org/302603013/diff/10001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:41148: +  <int value="4" label="Edit
Profile Image Account in Menu">
On 2014/05/28 18:22:39, Monica Dinculescu wrote:
> nit: why 'profile image account' and not just 'profile image'?

Because copy copy paste paste.

Done.

[Alexei Svitkine (slow), 2014-05-28 18:47:48]

histograms lgtm

[msw, 2014-05-28 20:24:38]

lgtm, but how about cocoa? Hopefully they'll track the same actions there
(*starting* to edit image) and (*finished* editing name).

[Mike Lerman, 2014-05-28 20:28:04]

On 2014/05/28 20:24:38, msw wrote:
> lgtm, but how about cocoa? Hopefully they'll track the same actions there
> (*starting* to edit image) and (*finished* editing name).

Cocoa will be added in a different CL. The Cocoa CL will also include the
metrics that were introduced here:
https://codereview.chromium.org/288493008/

The Cocoa CL in the works is here: https://codereview.chromium.org/308433002/,
and once this CL lands, I'll incorporate the new metrics into that CL.

Thanks, reviewers!

[Mike Lerman, 2014-05-28 20:28:09]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-05-28 20:28:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/302603013/30001

[commit-bot: I haz the power, 2014-05-28 23:54:07]

Change committed as 273407