tools/metrics/histograms/histograms.xml - Issue 302603013: UMA for modifying the profile image/name in the menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 302603013: UMA for modifying the profile image/name in the menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Nit Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 5265c80f2b4c090461ae32840ccadf8dee69e850..42ae1b58273bafcd22301730463aa2c31f253418 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -41133,15 +41133,21 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</enum>

- <int value="0" label="Locked In Menu from Button">

+ <int value="0" label="Locked In Menu">

noms (inactive) 2014/05/28 18:22:39 nit: 'in' isn't capitalized anywhere else. Also, s

Mike Lerman 2014/05/28 18:37:02 That is a very nitty nit. I like it! Done.

User opened the user menu, and clicked lock.

</int>

- <int value="1" label="Remove Account in Menu from Button.">

+ <int value="1" label="Remove Account in Menu">

User opened the user menu, and removed an account.

</int>

- <int value="2" label="Add Account in Menu from Button">

+ <int value="2" label="Add Account in Menu">

User opened the user menu, and started adding an account.

</int>

+ <int value="3" label="Edit Profile Name in Menu">

+ User opened the user menu, and changed the profile name.

+ </int>

+ <int value="4" label="Edit Profile Image Account in Menu">

noms (inactive) 2014/05/28 18:22:39 nit: why 'profile image account' and not just 'pro

Mike Lerman 2014/05/28 18:37:02 Because copy copy paste paste. Done.

+ User opened the user menu, and started selecting a new profile image.

+ </int>

</enum>

« no previous file with comments | « chrome/browser/ui/views/profiles/profile_chooser_view.cc ('k') | no next file » | no next file with comments »