Zoom Extension API (content changes)

content/common/view_messages.h

Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index 5505194094069fb349b16cd194f9ef61ca55a80a..b5e3998145226348794b4fe55d7be9e0683199ca 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -681,10 +681,16 @@ IPC_MESSAGE_ROUTED2(ViewMsg_SetZoomLevelForLoadingURL,
 // Set the zoom level for a particular url, so all render views
 // displaying this url can update their zoom levels to match.
 // If scheme is empty, then only host is used for matching.
-IPC_MESSAGE_CONTROL3(ViewMsg_SetZoomLevelForCurrentURL,
+// Render views in the exception list do not have their levels changed.
+IPC_MESSAGE_CONTROL4(ViewMsg_SetZoomLevelForCurrentURL,
                      std::string /* scheme */,
                      std::string /* host */,
-                     double /* zoom_level */)
+                     double /* zoom_level */,
+                     std::set<int> /* exceptions */)

[Fady Samuel, 2014/06/10 14:24:27]

I'm still not particularly comfortable about this exceptions list. A developer
coming in to add new zoom functionality would not have an understanding of why
there's an exception list. Also, it's not clear how SetZoomLevelForView
interacts with SetZoomLevelForCurrentURL.

If the exception bit is renderer-side, set form the other IPC (renaming the
other IPC to highlight the terminology "TemporaryZoomLevel"), then it becomes
clear how these two IPCs mesh together.

+
+// Set the zoom level for a particular render view.
+IPC_MESSAGE_ROUTED1(ViewMsg_SetZoomLevelForView,
+                    double /* zoom_level */)
 
 // Change encoding of page in the renderer.
 IPC_MESSAGE_ROUTED1(ViewMsg_SetPageEncoding,