Zoom Extension API (content changes)

content/common/view_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for page rendering.
 // Multiply-included message file, hence no include guard.
 
 #include "base/memory/shared_memory.h"
 #include "base/process/process.h"
 #include "base/strings/string16.h"
@@ skipping 663 matching lines @@
 // Set the zoom level for a particular url that the renderer is in the
 // process of loading.  This will be stored, to be used if the load commits
 // and ignored otherwise.
 IPC_MESSAGE_ROUTED2(ViewMsg_SetZoomLevelForLoadingURL,
                     GURL /* url */,
                     double /* zoom_level */)
 
 // Set the zoom level for a particular url, so all render views
 // displaying this url can update their zoom levels to match.
 // If scheme is empty, then only host is used for matching.
-IPC_MESSAGE_CONTROL3(ViewMsg_SetZoomLevelForCurrentURL,
+// Render views in the exception list do not have their levels changed.
+IPC_MESSAGE_CONTROL4(ViewMsg_SetZoomLevelForCurrentURL,
                      std::string /* scheme */,
                      std::string /* host */,
-                     double /* zoom_level */)
+                     double /* zoom_level */,
+                     std::set<int> /* exceptions */)

[Fady Samuel, 2014/06/10 14:24:27]

I'm still not particularly comfortable about this exceptions list. A developer
coming in to add new zoom functionality would not have an understanding of why
there's an exception list. Also, it's not clear how SetZoomLevelForView
interacts with SetZoomLevelForCurrentURL.

If the exception bit is renderer-side, set form the other IPC (renaming the
other IPC to highlight the terminology "TemporaryZoomLevel"), then it becomes
clear how these two IPCs mesh together.

+
+// Set the zoom level for a particular render view.
+IPC_MESSAGE_ROUTED1(ViewMsg_SetZoomLevelForView,
+                    double /* zoom_level */)
 
 // Change encoding of page in the renderer.
 IPC_MESSAGE_ROUTED1(ViewMsg_SetPageEncoding,
                     std::string /*new encoding name*/)
 
 // Reset encoding of page in the renderer back to default.
 IPC_MESSAGE_ROUTED0(ViewMsg_ResetPageEncodingToDefault)
 
 // Used to tell a render view whether it should expose various bindings
 // that allow JS content extended privileges.  See BindingsPolicy for valid
@@ skipping 1027 matching lines @@
 // synchronously (see crbug.com/120597). This IPC message sends the character
 // bounds after every composition change to always have correct bound info.
 IPC_MESSAGE_ROUTED2(ViewHostMsg_ImeCompositionRangeChanged,
                     gfx::Range /* composition range */,
                     std::vector<gfx::Rect> /* character bounds */)
 #endif
 
 // Adding a new message? Stick to the sort order above: first platform
 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform
 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg.