Use changed_button_flags() when converting MouseEvent to blink::WebMouseEvent.

Use changed_button_flags() when converting MouseEvent to blink::WebMouseEvent.

Event::flags() contains all the buttons that are being held down during the event, while MouseEvent::changed_button_flags() contains the buttons that are actually pressed/released during the event (and this is what we really are interested in).

This fixes the issue with LMB being pressed while RMB is being held down. Without the fix, we always get blink::WebMouseEvent::ButtonRight in blink::WebMouseEvent::button.

Committed: https://crrev.com/87e6b0f6d72b12e4b0308b035d1c06f2beb90feb
Cr-Commit-Position: refs/heads/master@{#293487}

[joleksy, 2014-05-26 06:53:42]

@reviewer: does it look ok to you?

[Ben Goodger (Google), 2014-05-27 15:54:37]

lgtm

[joleksy, 2014-09-04 07:33:22]

On 2014/05/27 15:54:37, Ben Goodger (Google) wrote:
> lgtm

Hey,
do we have a chance of having this integrated?:-)

[joleksy, 2014-09-05 07:36:20]

The CQ bit was checked by joleksy@opera.com

[commit-bot: I haz the power, 2014-09-05 07:37:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/joleksy@opera.com/302593002/20001

[joleksy, 2014-09-05 07:41:44]

On 2014/09/05 07:37:56, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/joleksy@opera.com/302593002/20001

I was not aware of the "Commit" checkbox...

[commit-bot: I haz the power, 2014-09-05 10:09:26]

Committed patchset #2 (id:20001) as c4471b43ad445a76fa0a1408b85c11c945d2e830

[commit-bot: I haz the power, 2014-09-10 03:38:23]

Patchset 2 (id:??) landed as
https://crrev.com/87e6b0f6d72b12e4b0308b035d1c06f2beb90feb
Cr-Commit-Position: refs/heads/master@{#293487}

[Lei Zhang, 2014-09-11 09:33:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/563713002/ by thestig@chromium.org.

The reason for reverting is: Aura builds fail DCHECKs:

ASSERTION FAILED: event.type() == PlatformEvent::MouseMoved || event.button() !=
NoButton
third_party/WebKit/Source/core/events/MouseEvent.cpp(54)

blink::MouseEvent::create()
blink::Node::dispatchMouseEvent()
blink::EventHandler::dispatchMouseEvent()
blink::EventHandler::handleMousePressEvent()
blink::PageWidgetEventHandler::handleMouseDown()
blink::WebViewImpl::handleMouseDown()
blink::WebViewImpl::handleMouseDown()
blink::PageWidgetDelegate::handleInputEvent()
blink::WebViewImpl::handleInputEvent()
content::RenderWidget::OnHandleInputEvent().

[joleksy, 2014-09-11 11:28:50]

On 2014/09/11 09:33:45, Lei Zhang wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/563713002/ by mailto:thestig@chromium.org.
> 
> The reason for reverting is: Aura builds fail DCHECKs:
> 
> ASSERTION FAILED: event.type() == PlatformEvent::MouseMoved || event.button()
!=
> NoButton
> third_party/WebKit/Source/core/events/MouseEvent.cpp(54)
> 
> blink::MouseEvent::create()
> blink::Node::dispatchMouseEvent()
> blink::EventHandler::dispatchMouseEvent()
> blink::EventHandler::handleMousePressEvent()
> blink::PageWidgetEventHandler::handleMouseDown()
> blink::WebViewImpl::handleMouseDown()
> blink::WebViewImpl::handleMouseDown()
> blink::PageWidgetDelegate::handleInputEvent()
> blink::WebViewImpl::handleInputEvent()
> content::RenderWidget::OnHandleInputEvent().

Does it happen on Windows or Linux? Is the DCHECK hit immediately at startup?
I cannot reproduce it on Linux, and it seems to me that the only case when it
would occur (i.e. changed_button_flags() not set for MousePressed &
MouseReleased) is in testing (because GetChangedMouseButtonFlagsFromNative()
returns 0 in events_stub.cc, but it has NOTIMPLEMETED() as well).

[joleksy, 2014-09-11 12:00:46]

On 2014/09/11 11:28:50, joleksy wrote:
> On 2014/09/11 09:33:45, Lei Zhang wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/563713002/ by mailto:thestig@chromium.org.
> > 
> > The reason for reverting is: Aura builds fail DCHECKs:
> > 
> > ASSERTION FAILED: event.type() == PlatformEvent::MouseMoved ||
event.button()
> !=
> > NoButton
> > third_party/WebKit/Source/core/events/MouseEvent.cpp(54)
> > 
> > blink::MouseEvent::create()
> > blink::Node::dispatchMouseEvent()
> > blink::EventHandler::dispatchMouseEvent()
> > blink::EventHandler::handleMousePressEvent()
> > blink::PageWidgetEventHandler::handleMouseDown()
> > blink::WebViewImpl::handleMouseDown()
> > blink::WebViewImpl::handleMouseDown()
> > blink::PageWidgetDelegate::handleInputEvent()
> > blink::WebViewImpl::handleInputEvent()
> > content::RenderWidget::OnHandleInputEvent().
> 
> Does it happen on Windows or Linux? Is the DCHECK hit immediately at startup?
> I cannot reproduce it on Linux, and it seems to me that the only case when it
> would occur (i.e. changed_button_flags() not set for MousePressed &
> MouseReleased) is in testing (because GetChangedMouseButtonFlagsFromNative()
> returns 0 in events_stub.cc, but it has NOTIMPLEMETED() as well).

It can be 0 also in some weird cases, the fix is to check whether the flags are
actually set.

[joleksy, 2014-09-11 13:57:08]

Not sure if the update mail was sent when the issue was closed so I am sending
message again after reopening Fixed the DCHECK.

[joleksy, 2014-09-18 14:02:25]

On 2014/09/11 13:57:08, joleksy wrote:
> Not sure if the update mail was sent when the issue was closed so I am sending
> message again after reopening Fixed the DCHECK.

Hello?:-)

[joleksy, 2014-09-22 07:44:06]

On 2014/09/18 14:02:25, joleksy wrote:
> On 2014/09/11 13:57:08, joleksy wrote:
> > Not sure if the update mail was sent when the issue was closed so I am
sending
> > message again after reopening Fixed the DCHECK.
> 
> Hello?:-)

Seems to be forgotten so I created a new one:
https://codereview.chromium.org/585393002/