Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 302543008: Reset DocumentLoader::m_request's method to GET for pushState and replaceState (Closed)

Created:
6 years, 6 months ago by Nate Chapin
Modified:
6 years, 6 months ago
Reviewers:
dglazkov
CC:
blink-reviews, gavinp+loader_chromium.org
Visibility:
Public.

Description

Reset DocumentLoader::m_request's method to GET for pushState and replaceState We currently correctly send a GET in the POST->replaceState->reload case, but DocumentLoader::m_request still shows a method of POST, and as a result we incorrectly report it as a POST to the browser process. This contributes to unnecessarily showing a form resubmission warning in that case. BUG=138324 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175011

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M Source/core/loader/DocumentLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
Nate Chapin
https://codereview.chromium.org/302543008/diff/20001/Source/core/loader/FrameLoader.cpp File Source/core/loader/FrameLoader.cpp (left): https://codereview.chromium.org/302543008/diff/20001/Source/core/loader/FrameLoader.cpp#oldcode288 Source/core/loader/FrameLoader.cpp:288: m_currentItem->setFormInfoFromRequest(isPushOrReplaceState ? ResourceRequest() : m_documentLoader->request()); This special case is ...
6 years, 6 months ago (2014-05-28 21:26:15 UTC) #1
dglazkov
lgtm pretty.
6 years, 6 months ago (2014-05-28 21:38:06 UTC) #2
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 6 months ago (2014-05-28 21:39:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/302543008/20001
6 years, 6 months ago (2014-05-28 21:39:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-28 22:45:16 UTC) #5
commit-bot: I haz the power
Change committed as 175011
6 years, 6 months ago (2014-05-28 23:35:44 UTC) #6
Nate Chapin
6 years, 6 months ago (2014-05-28 23:49:19 UTC) #7
Message was sent while issue was closed.
On 2014/05/28 23:35:44, I haz the power (commit-bot) wrote:
> Change committed as 175011

Oops. That was supposed to be
https://code.google.com/p/chromium/issues/detail?id=239907 in the commit
message.

Powered by Google App Engine
This is Rietveld 408576698