Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 302543008: Reset DocumentLoader::m_request's method to GET for pushState and replaceState (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FrameLoader.cpp
diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp
index 3cefb06953460726a3caafbfaa1f0fbe6a74b7ee..16fb7acdb782495a4337dab7a859b962196ba1ef 100644
--- a/Source/core/loader/FrameLoader.cpp
+++ b/Source/core/loader/FrameLoader.cpp
@@ -285,7 +285,7 @@ void FrameLoader::setHistoryItemStateForCommit(HistoryCommitType historyCommitTy
if (isPushOrReplaceState)
m_currentItem->setStateObject(stateObject);
m_currentItem->setReferrer(Referrer(m_documentLoader->request().httpReferrer(), m_documentLoader->request().referrerPolicy()));
- m_currentItem->setFormInfoFromRequest(isPushOrReplaceState ? ResourceRequest() : m_documentLoader->request());
Nate Chapin 2014/05/28 21:26:16 This special case is no longer necessary, as setFo
+ m_currentItem->setFormInfoFromRequest(m_documentLoader->request());
}
static HistoryCommitType loadTypeToCommitType(FrameLoadType type)
@@ -532,7 +532,7 @@ void FrameLoader::updateForSameDocumentNavigation(const KURL& newURL, SameDocume
{
// Update the data source's request with the new URL to fake the URL change
m_frame->document()->setURL(newURL);
- documentLoader()->updateForSameDocumentNavigation(newURL);
+ documentLoader()->updateForSameDocumentNavigation(newURL, sameDocumentNavigationSource);
// Generate start and stop notifications only when loader is completed so that we
// don't fire them for fragment redirection that happens in window.onload handler.
« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698