Issue 302443010: Revert 273079 "Add content renderer to the GN build"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302443010: Revert 273079 "Add content renderer to the GN build" (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 273079 "Add content renderer to the GN build" > Add content renderer to the GN build > > Also adds ui/native_theme, third_party/npapi, and some required mojo stuff to make it build. > > BUG= > R=scottmg@chromium.org > > Review URL: https://codereview.chromium.org/299113002 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273086

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+249 lines, -549 lines)			Patch
M	trunk/src/BUILD.gn	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/build/config/BUILD.gn	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/build/config/features.gni	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/content/BUILD.gn	View	3 chunks	+1 line, -27 lines	0 comments	Download
M	trunk/src/content/common/BUILD.gn	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	trunk/src/content/content_renderer.gypi	View	4 chunks	+241 lines, -246 lines	0 comments	Download
M	trunk/src/content/public/common/BUILD.gn	View	1 chunk	+2 lines, -1 line	0 comments	Download
D	trunk/src/content/public/renderer/BUILD.gn	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	trunk/src/content/renderer/BUILD.gn	View	1 chunk	+0 lines, -176 lines	0 comments	Download
D	trunk/src/content/renderer/renderer.gni	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	trunk/src/mojo/public/interfaces/shell/BUILD.gn	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	trunk/src/third_party/npapi/BUILD.gn	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	trunk/src/ui/native_theme/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

brettw

6 years, 6 months ago (2014-05-28 00:25:47 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r273086 (tree was closed).